From 3ecfd0f95faa5cee568403d24ee5563022f3301c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez?= Date: Sat, 19 Sep 2020 10:57:56 -0400 Subject: [PATCH 1/3] [Identity] Fix broken eslint in the builds --- .../identity/test/public/clientCertificateCredential.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/sdk/identity/identity/test/public/clientCertificateCredential.spec.ts b/sdk/identity/identity/test/public/clientCertificateCredential.spec.ts index e5813931a605..278e4ba596e4 100644 --- a/sdk/identity/identity/test/public/clientCertificateCredential.spec.ts +++ b/sdk/identity/identity/test/public/clientCertificateCredential.spec.ts @@ -8,7 +8,6 @@ import assert from "assert"; import { ClientCertificateCredential } from "../../src"; import { MockAuthHttpClient } from "../authTestUtils"; import { setTracer, TestTracer, SpanGraph } from "@azure/core-tracing"; -import { ClientCertificateCredentialOptions } from "../../src/credentials/clientCertificateCredentialOptions"; describe("ClientCertificateCredential", function() { it("loads a PEM-formatted certificate from a file", () => { From 479a9432722d6dadda8747f23bc14757c642bee9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez?= Date: Sat, 19 Sep 2020 11:11:01 -0400 Subject: [PATCH 2/3] .eslintignore was being ignored --- sdk/identity/identity/.eslintignore | 2 -- sdk/identity/identity/.eslintrc.json | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) delete mode 100644 sdk/identity/identity/.eslintignore diff --git a/sdk/identity/identity/.eslintignore b/sdk/identity/identity/.eslintignore deleted file mode 100644 index 9e679be63366..000000000000 --- a/sdk/identity/identity/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -test/manual/ -test/manual-integration/ diff --git a/sdk/identity/identity/.eslintrc.json b/sdk/identity/identity/.eslintrc.json index c6695b65bc04..3c02098c367d 100644 --- a/sdk/identity/identity/.eslintrc.json +++ b/sdk/identity/identity/.eslintrc.json @@ -1,7 +1,7 @@ { "plugins": ["@azure/azure-sdk"], "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], - "ignorePatterns": ["src/core"], + "ignorePatterns": ["src/core", "test/manual*"], "rules": { "@azure/azure-sdk/ts-naming-options": "warn" } From 40de8ee65be03025818ec554221bde19e952bd73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Rodr=C3=ADguez?= Date: Mon, 21 Sep 2020 15:16:11 -0400 Subject: [PATCH 3/3] Feedback by Deya --- sdk/identity/identity/.eslintrc.json | 2 +- sdk/identity/identity/tsconfig.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/identity/identity/.eslintrc.json b/sdk/identity/identity/.eslintrc.json index 3c02098c367d..8eb21b5d1c3e 100644 --- a/sdk/identity/identity/.eslintrc.json +++ b/sdk/identity/identity/.eslintrc.json @@ -1,7 +1,7 @@ { "plugins": ["@azure/azure-sdk"], "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], - "ignorePatterns": ["src/core", "test/manual*"], + "ignorePatterns": ["test/manual*"], "rules": { "@azure/azure-sdk/ts-naming-options": "warn" } diff --git a/sdk/identity/identity/tsconfig.json b/sdk/identity/identity/tsconfig.json index bf0d06868733..37081195b9c1 100644 --- a/sdk/identity/identity/tsconfig.json +++ b/sdk/identity/identity/tsconfig.json @@ -54,6 +54,6 @@ // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ "forceConsistentCasingInFileNames": true }, - "include": ["src/**/*", "test/*", "test/manual/**/*", "test/internal/**/*", "test/public/**/*"], - "exclude": ["test/manual", "node_modules"] + "include": ["src/**/*", "test/**/*"], + "exclude": ["test/manual*/**/*", "node_modules"] }