Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[service-bus] investigate porting TypeError fixes from event-hubs #9914

Closed
chradek opened this issue Jul 6, 2020 · 1 comment
Closed

[service-bus] investigate porting TypeError fixes from event-hubs #9914

chradek opened this issue Jul 6, 2020 · 1 comment
Assignees
@chradek
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] August

Comments

@chradek
Copy link
Contributor

chradek commented Jul 6, 2020

In #8584 we investigated the cause of some TypeErrors being thrown from rhea-promise and found that there was a race condition where the event-hubs package could re-open a rhea connection before creating a new connection. This caused the rhea connection's state to become unpredictable and have adverse affects.

We should look at the changes made in #8884 that addressed this in event hubs and consider if they need to be ported to service-bus as well.
@chradek chradek added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jul 6, 2020
@chradek chradek added this to the [2020] August milestone Jul 6, 2020
This was referenced Jul 9, 2020
Closed
Merged
Merged
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Jul 14, 2020
@chradek
Copy link
Contributor Author

chradek commented Jul 21, 2020

This has been completed by #10046 and #10051

@chradek chradek closed this as completed Jul 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chradek chradek

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] August
Development

No branches or pull requests
2 participants
@ramya-rao-a @chradek