Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint-plugin-azure-sdk] Rule "@azure/azure-sdk/ts-no-namespaces" is redundant #8717

Closed
willmtemple opened this issue May 6, 2020 · 2 comments · Fixed by #18676
Closed

[eslint-plugin-azure-sdk] Rule "@azure/azure-sdk/ts-no-namespaces" is redundant #8717

willmtemple opened this issue May 6, 2020 · 2 comments · Fixed by #18676
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@willmtemple
Copy link
Contributor

willmtemple commented May 6, 2020 •
edited by witemple-msft
Loading

There is already a rule in typescript-eslint for this purpose, so we don't need our own custom rule for it.

We can remove src/rules/ts-no-namespaces.ts from common/tools/eslint-plugin-azure-sdk and update the base config to use typescript-eslint/no-namespace instead. We'll need to make sure that the linter works with all packages afterwards (rush lint).

See the docs on the typescript-eslint repo.
@willmtemple willmtemple added this to the Backlog milestone May 6, 2020
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jul 20, 2020
@deyaaeldeen deyaaeldeen modified the milestones: Backlog, MQ-2020 Nov 17, 2020
@deyaaeldeen deyaaeldeen self-assigned this Nov 17, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, Backlog Dec 17, 2020
@witemple-msft witemple-msft added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Jul 26, 2021
@ramya-rao-a
Copy link
Contributor

Code pointers for those interested to contributing a fix to this issue:

@bbrusniak bbrusniak mentioned this issue Nov 14, 2021
Merged
@bbrusniak
Copy link
Contributor

I have attempted to implement a fix for this issue in this PR: #18676

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. eslint plugin help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
6 participants
@xirzec @willmtemple @deyaaeldeen @ramya-rao-a @bbrusniak @witemple-msft