Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Azure.Identity - Support KnownAuthorities like Python SDK #7597

Closed
jongio opened this issue Feb 29, 2020 · 7 comments
Closed
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@jongio
Copy link
Member

jongio commented Feb 29, 2020

Azure.Identity

It would be great if we provided a "KnownAuthorities" concept, like we have in the Python SDK.
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/identity/azure-identity/azure/identity/_constants.py

Right now, in JS, devs have to provide the url for the environment they are targeting https://login.microsoftonline.us for Gov, for example.

With Python

credential = DefaultAzureCredential(authority=KnownAuthorities.AZURE_GOVERNMENT)

With JS

const credential = new DefaultAzureCredential({ authorityHost: "https://login.microsoftonline.us" });
@xirzec xirzec added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Mar 2, 2020
@xirzec
Copy link
Member

xirzec commented Mar 2, 2020

/cc @jonathandturner

@jongio
Copy link
Member Author

jongio commented Mar 10, 2020

@jonathandturner - Can we try to get this in April? We have .net and python done.

@jongio
Copy link
Member Author

jongio commented Mar 13, 2020

While Python uses the name KnownAuthorities, KnownAuthorityHosts looks like the better name for the other languages.

@sophiajt
Copy link
Contributor

Yes, we should be able to. Should I grab the list of known authorities from the python version?

@jongio
Copy link
Member Author

jongio commented Mar 15, 2020

Yep. Thanks 🙏

@sophiajt
Copy link
Contributor

Current PR: #7829

@jongio
Copy link
Member Author

jongio commented Mar 27, 2020

#7829 Merged into master, so closing this issue.

@jongio jongio closed this as completed Mar 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

4 participants