[Storage] full url should be used in BatchRequest multi-part API

[jeremymeng]

There's a customer reported issue for python where token credential would fail to work with batch request that doesn't have full url.

Azure/azure-sdk-for-python#9534

I believe we have same issue as we only use the path and query

    this.body += [
      this.subRequestPrefix, // sub request constant prefix
      `${HeaderConstants.CONTENT_ID}: ${this.operationCount}`, // sub request's content ID
      "", // empty line after sub request's content ID
      `${request.method.toString()} ${getURLPathAndQuery(
        request.url
      )} ${HTTP_VERSION_1_1}${HTTP_LINE_ENDING}` // sub request start line with method
    ].join(HTTP_LINE_ENDING);

[ljian3377]

Are you suggesting use request.url directly instead of getURLPathAndQuery( request.url).

    this.body += [
      this.subRequestPrefix, // sub request constant prefix
      `${HeaderConstants.CONTENT_ID}: ${this.operationCount}`, // sub request's content ID
      "", // empty line after sub request's content ID
      `${request.method.toString()} ${request.url} ${HTTP_VERSION_1_1}${HTTP_LINE_ENDING}` // sub request start line with method
    ].join(HTTP_LINE_ENDING);

[jeremymeng]

Yes

[voidfoo]

Although we might not have a bug because we might not have the credential similar to what python has (beakTokenCredentialPolicy in the linked issue)

[ljian3377]

We do have the same issue. Reproduced in #12212
But I am not sure if using full url is the right fix.

Updates:
Actually the repro in 097a676 was due to another issue #12219.

[ljian3377]

We don't have the same issue. According to the REST API doc: https://docs.microsoft.com/en-us/rest/api/storageservices/blob-batch

• The subrequest URL should only have the path of the URL (i.e without the host).
• Each subrequest will be authorized and authorized separately with the provided information in the subrequest.

And we are correctly assembling the sub requests. For example, in this test case, 4a80d44

--batch_e4a717e2-8ebf-43ea-a609-115d833ca9b9
Content-Type: application/http
Content-Transfer-Encoding: binary
Content-ID: 0

DELETE /container160429459257406184/blob0 HTTP/1.1
authorization: Bearer eyJ...

--batch_e4a717e2-8ebf-43ea-a609-115d833ca9b9
Content-Type: application/http
Content-Transfer-Encoding: binary
Content-ID: 1

DELETE /container160429459257406184/blob1 HTTP/1.1
authorization: Bearer eyJ...

--batch_e4a717e2-8ebf-43ea-a609-115d833ca9b9
Content-Type: application/http
Content-Transfer-Encoding: binary
Content-ID: 2

DELETE /container160429459257406184/%C3%A5%20%C3%A4%20%C3%B6 HTTP/1.1
authorization: Bearer eyJ...

--batch_e4a717e2-8ebf-43ea-a609-115d833ca9b9--