Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Add createBatch() to Sender #7067

Closed
ramya-rao-a opened this issue Jan 22, 2020 · 4 comments
Closed

[Service Bus] Add createBatch() to Sender #7067

ramya-rao-a opened this issue Jan 22, 2020 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 22, 2020

The sendBatch() method on the sender in Service Bus today allows users to send multiple messages by batching them into a single message. Currently, there is no way for the user to ensure that they dont go over the allowed max size for a batch. They have to send first, and then examine the error that gets thrown in such cases.

This issue is to add a createBatch() to the sender just like we did in Event Hubs to return a "batch" to the user which they can then fill one by one until the max size is reached.

Please refer to the implementation in Event Hubs as a reference.

This work needs to happen in the feature/service-bus-track-2 branch

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jan 22, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] March milestone Jan 22, 2020
@Pruxis
Copy link

Pruxis commented Jan 24, 2020

Also what we have noticed is that by sending multiple messages everytime a event listener is created, meaning when sending large amounts of messages in parallel or in batch your server can go out of memory.

@ramya-rao-a
Copy link
Contributor Author

Thanks for the feedback @Pruxis!
That concern should be taken care of in #6903

@HarshaNalluru
Copy link
Member

Draft #7527

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Mar 19, 2020

Merged #7527

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants