Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@azure/abort-controller can't use AbortSignal with window.fetch in chrome #5531

Closed
1 of 6 tasks
joheredi opened this issue Oct 11, 2019 · 1 comment
Closed
1 of 6 tasks
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@joheredi
Copy link
Member

joheredi commented Oct 11, 2019

  • Package Name: @azure/abort-controller
  • Package Version: 1.0.0-preview.2
  • Operating system: Windows
  • nodejs
    • version:
  • browser
    • name/version: Chrome / 77.0.3865.90
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
Fetch throws an error when called with AbortSignal
Failed to execute 'fetch' on 'Window': member signal is not of type AbortSignal.

To Reproduce
Steps to reproduce the behavior:

import { AbortController } from "@azure/abort-controller";

const controller = new AbortController();
const signal = controller.signal;

fetch("https://www.google.com", { signal })
  .then(response => response.json())
  .then(content => {
    console.log(content);
  });

Expected behavior
AbortSignal should be compatible with Standard AbortSignal

Additional context
Seems to be working fine in Edge

@maggiepint maggiepint added the Client This issue points to a problem in the data-plane of the library. label Oct 12, 2019
@ramya-rao-a ramya-rao-a added Azure.Core blocking-release Blocks release and removed blocking-release Blocks release labels Oct 14, 2019
@ramya-rao-a ramya-rao-a added this to the [2020] February milestone Dec 16, 2019
@xirzec xirzec modified the milestones: [2020] February, [2020] March Mar 2, 2020
@xirzec xirzec modified the milestones: [2020] March, [2020] May Apr 21, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] May, Backlog May 14, 2020
Copy link

Hi @joheredi, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

5 participants