[KeyVault] Preview #4 - release testing

[sophiajt]

Keys

• Line 40 helloWorld.ts - Missing ! on version

const updatedKey = await client.updateKey(keyName, result.properties.version, { enabled: false });

Secrets

• Line 26 helloWorld.ts - Missing ! on version

  const updatedSecret = await client.updateSecretProperties(secretName, result.properties.version, {
    enabled: false
  });

• Line 47 backupAndRestore.ts - Missing ! on backupResult

await writeFile("secret_backup.dat", backupResult);

Certificates

• Line 38 helloWorld.ts - Missing ! on version

certificateWithPolicy.properties.version

• Line 44 issuers.ts - 'certificate' declared but never read

const certificate = await client.getCertificate("MyCertificate", "");

• issuers.ts - error when running: "Issuer not found"
• backupAndRestore.ts - error when running: "Certificate is currently being deleted." Are the delays sufficient here?
• contacts.ts - error when running: "Contacts not found"
• operations.ts - error when running "The 'version' cannot be empty." Seems to be erroring on getCertificate

[sadasant]

Oh this is specifically about the samples.

[sadasant]

Notes:

• Our samples are being built on CI too. I wonder why we're not catching these.
• "Issuer not found" and "Contacts not found" <-- Are these errors? We're catching the errors in the samples to show that the resources have been deleted.

[sadasant]

I created some config files called tsconfig.samples.json and changed the samples build script. I was able to catch and fix all of the feedback here and more! 🌞