Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Consider having blobUriBuilder to parse URLs #5329

Closed
HarshaNalluru opened this issue Oct 1, 2019 · 4 comments
Closed

[Storage] Consider having blobUriBuilder to parse URLs #5329

HarshaNalluru opened this issue Oct 1, 2019 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@HarshaNalluru
Copy link
Member

Future improvements - using a blobUriBuilder that supports extracting blob specific components from a url.

Reference - #5316 (comment)

@HarshaNalluru HarshaNalluru added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 1, 2019
@triage-new-issues triage-new-issues bot removed the triage label Oct 1, 2019
@jeremymeng
Copy link
Member

Non-breaking improvement.

@ljian3377
Copy link
Member

We have getBlobAndContainerNamesFromUrl so I think we are good?

private getBlobAndContainerNamesFromUrl(): { blobName: string; containerName: string } {

@HarshaNalluru
Copy link
Member Author

The intention behind this issue is to make a method(or a class with a constructor) that would take a connection string as the input, and return an object with the key-value pairs from connection string.

That would probably consolidate getBlobAndContainerNamesFromUrl, getValueInConnectionString, extractConnectionStringParts and getAccountNameFromUrl.(logic in these would still be relevant)

If you don't think it's worth doing it, feel free to close the issue. 🙂

@ljian3377
Copy link
Member

Close this since the code logic are stablized and I don't see the urgent need of refactoring.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

4 participants