Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing doNotRunExtensionsOnOverprovisionedVMs in @azure/arm-compute model and docs #5292

Closed
4 of 6 tasks
michax opened this issue Sep 29, 2019 · 10 comments
Closed
4 of 6 tasks
Assignees
Labels
Compute - VMSS customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@michax
Copy link

michax commented Sep 29, 2019

  • Package Name: @azure/arm-compute
  • Package Version: 11.0.0
  • Operating system: Windows 10
  • nodejs
    • version: 10.15.3
  • browser
    • name/version:
  • typescript
    • version: node package: 3.3.3, tsc: 1.5.3
  • Is the bug related to documentation in

Describe the bug
Missing property doNotRunExtensionsOnOverprovisionedVMs in ComputeManagementModels.VirtualMachineScaleSetUpdate typescript interface from @azure/arm-compute. This property is supported by 2019-03-01 api version:
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachinescalesets/update

This property is also missing in sdk references:
https://azure.github.io/azure-sdk-for-js/arm-compute/interfaces/virtualmachinescalesetupdate.html

To Reproduce
Steps to reproduce the behavior:

  1. Go to @azure/arm-comptue docs: https://azure.github.io/azure-sdk-for-js/arm-compute/interfaces/virtualmachinescalesetupdate.html
  2. Property "doNotRunExtensionsOnOverprovisionedVMs" is missing there. And it's missing in typescript interface as well.

Expected behavior
New vmss property called "doNotRunExtensionsOnOverprovisionedVMs" should be added both to docs and typescript interface "ComputeManagementModels.VirtualMachineScaleSetUpdate"

Screenshots
image
image

@maggiepint maggiepint added Compute - VMSS customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. labels Oct 1, 2019
@triage-new-issues triage-new-issues bot removed the triage label Oct 1, 2019
@ghost
Copy link

ghost commented Oct 1, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mjconnection, @Drewm3

1 similar comment
@ghost
Copy link

ghost commented Oct 1, 2019

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @mjconnection, @Drewm3

@Drewm3 Drewm3 self-assigned this Oct 1, 2019
@Drewm3
Copy link
Member

Drewm3 commented Oct 1, 2019

Hi @michax, I am checking with the dev team to make sure the definition for this API is documented correctly. If everything is correct on the VMSS API side, then I will move this over to the java script SDK team to determine why this property is not showing up in the current SDK.

@ruowan
Copy link
Member

ruowan commented Oct 11, 2019

Hi, @michax . The property doNotRunExtensionsOnOverprovisionedVMs is defined here https://azure.github.io/azure-sdk-for-js/arm-compute/interfaces/virtualmachinescaleset.html.

@Drewm3
Copy link
Member

Drewm3 commented Oct 11, 2019

@michax, please let me know if ruowan's comment clarifies things. If it does, then I'll close this issue.

@michax
Copy link
Author

michax commented Oct 12, 2019

@ruowan @Drewm3 But shouldn't it also be part of actual method used for updating VMSS?
Currently I'm unable to pass doNotRunExtensionsOnOverprovisionedVMs in VMSS beginUpdate method payload.
https://azure.github.io/azure-sdk-for-js/arm-compute/interfaces/virtualmachinescalesetupdate.html

However i can easily update this value using just 'raw' rest api. I believe sdk should allow for the same with statically typed approach.

@ruowan
Copy link
Member

ruowan commented Oct 16, 2019

Hi @michax . You can try VirtualMachineScaleSets.createOrUpdate method which allow this property. I also agree with you. We will release a new version of this package after discussing it with team.

@yungezz
Copy link
Member

yungezz commented Oct 16, 2019

@michax
Copy link
Author

michax commented Oct 16, 2019

@ruowan Thanks!

@michax michax closed this as completed Oct 16, 2019
@ghost
Copy link

ghost commented Oct 16, 2019

Thanks for working with Microsoft on GitHub! Tell us how you feel about your experience using the reactions on this comment.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Compute - VMSS customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

5 participants