Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] EventHubSender sample using SAS and Publisher #5290

Closed
fashaikh opened this issue Sep 28, 2019 · 9 comments
Closed

[Event Hubs] EventHubSender sample using SAS and Publisher #5290

fashaikh opened this issue Sep 28, 2019 · 9 comments
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@fashaikh
Copy link

fashaikh commented Sep 28, 2019

Is there a way to use a sas connection string like this with the js sdk..
Cant find a way to mimic this https://docs.microsoft.com/en-us/dotnet/api/microsoft.servicebus.messaging.eventhubsender.createfromconnectionstring?view=azure-dotnet

Here is how the publisherSASUri looks like

"Endpoint=sb://sbname.servicebus.windows.net/;SharedAccessSignature=SharedAccessSignature sr=sb%3a%2f%2fsbname.servicebus.windows.net%2feventhubname%2fPublishers%2fpublishername&sig=signature&se=9999&skn=SendPolicy;EntityPath=EventHubName;Publisher=publishername"
@fashaikh fashaikh changed the title [Event Hubs] EventHub Sender sample using SAS and Publisher [Event Hubs] EventHubSender sample using SAS and Publisher Sep 28, 2019
@maggiepint maggiepint added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Oct 1, 2019
@triage-new-issues triage-new-issues bot removed the triage label Oct 1, 2019
@maggiepint
Copy link
Contributor

@fashaikh what version of the Event Hubs client are you using?

cc @jfggdl

@fashaikh
Copy link
Author

fashaikh commented Oct 1, 2019

"@azure/event-hubs": "^2.1.1",

@ramya-rao-a
Copy link
Contributor

Thanks for reporting @fashaikh
This is currently not possible to do in the 2.1.1 version of the event hubs library.

We are working on a new version of this library at the moment and will get back to this issue in January with updates if any

@ramya-rao-a ramya-rao-a added this to the [2020] February milestone Dec 8, 2019
@erwinbooij
Copy link

Hi there we are experiencing the same issue with the @azure/service-bus package, will this also be fixed in the same release?

@chradek chradek modified the milestones: [2020] March, [2020] April Mar 9, 2020
@chradek chradek removed their assignment Mar 9, 2020
@chradek chradek modified the milestones: [2020] April, Backlog Apr 1, 2020
@ramya-rao-a ramya-rao-a added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 4, 2020
@ramya-rao-a ramya-rao-a added the feature-request This issue requires a new behavior in the product in order be resolved. label Jul 19, 2020
@ramya-rao-a
Copy link
Contributor

@fashaikh, @erwinbooij,

Currently the connection string support in both Event Hubs and Service Bus libraries is restricted to having only the SharedAccessKey and SharedAccessKeyName in it, using which the library then creates the SAS token.

In the example shared in the issue description here, looks like what is being asked is the ability to pass in the SAS token itself in the connection string.

Can you share what design choices in your application leads you to require to pass the SAS token yourself rather than relying on the library to create it?

@Petermarcu Petermarcu added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jul 22, 2020
@daniekpo
Copy link

@ramya-rao-a in my case a different team is managing the event hub that we're writing to. They recently changed from issuing a connection string that has SharedAccessKey and SharedAccessKeyName properties to one that only has SharedAccessSignature. Apparently the .Net Core client can connect using this SAS token (as the team demonstrated in their documentation).

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Aug 5, 2020
@ghost
Copy link

ghost commented Aug 5, 2020

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ramya-rao-a ramya-rao-a removed needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. labels Aug 5, 2020
@ramya-rao-a
Copy link
Contributor

Removing the needs-author-feedback label as this is a feature request we have seen coming in via other channels for other languages as well. Keeping the issue open and in the backlog for now. We will look into how we can incorporate this into the new SDK this semester.

@ramya-rao-a
Copy link
Contributor

Hello all,

The latest Event Hubs package with version 5.3.0 and the latest preview of the Service Bus package with version 7.0.0-preview.6 now support taking connection string that has SharedAccessSignature specified.

Please give it a try and let us know if you see any issues with it.

Thanks for your patience!

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

9 participants