Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Optimize this.skip(); instead of return; in the test for TokenCredential. #5112

Closed
HarshaNalluru opened this issue Sep 12, 2019 · 1 comment
Closed

[Storage] Optimize this.skip(); instead of return; in the test for TokenCredential. #5112

HarshaNalluru opened this issue Sep 12, 2019 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Sep 12, 2019 •
edited
Loading

Tests that leverage ACCOUNT_TOKEN are being skipped in the CI integration tests due to the lack of a valid ACCOUNT_TOKEN.

image

Instead of "return"ing, we can leverage mocha's this.skip() to skip the test.
That way we can be sure we are not testing it when we don't have ACCOUNT_TOKEN.
@HarshaNalluru HarshaNalluru changed the title [Storage] this.skip() instead of return; in the test [Storage] this.skip(); instead of return; in the test Sep 12, 2019
@jiacfan jiacfan changed the title [Storage] this.skip(); instead of return; in the test [Storage] Optimize this.skip(); instead of return; in the test for TokenCredential. Sep 12, 2019
@loarabia loarabia added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) and removed triage labels Sep 12, 2019
@kurtzeborn kurtzeborn mentioned this issue Sep 16, 2019
Closed
26 tasks
@HarshaNalluru
Copy link
Member Author

#5236

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loarabia @HarshaNalluru