GraphRbacManagementClient fails when not setting baseUri explicitly

[johlrich]

• Package Name: @azure/graph
• Package Version: 4.3.0
• Operating system:
• nodejs
  • version: 10.15.0
• browser
  • name/version:
• typescript
  • version: 3.4.5
• Is the bug related to documentation in
  • README.md
  • source code documentation
  • SDK API docs on https://docs.microsoft.com

Describe the bug
When using a GraphRbacManagementClient, requests will fail if you do not explicitly set the baseUri to "https://graph.windows.net"

Error: {"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"Invalid domain name in the request url."},"requestId":"566b2d93-3895-4946-9cc8-8799bef068be","date":"2019-05-24T18:08:39"}}

To Reproduce
Steps to reproduce the behavior:

1. create GraphRbacManagementClient
2. call client.signedInUser.get()

Expected behavior
Expect to not need to set this explicitly.

Additional context
Add any other context about the problem here.

I believe the issue is the credentials I'm getting does have an environment (azcli based auth), which causes the base class to set the resourceManagerEndpointUrl as the baseUri: https://github.com/Azure/ms-rest-azure-js/blob/master/lib/azureServiceClient.ts#L46-L49
which prevents the Graph specific default from being respected: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/graphrbac/graph/src/graphRbacManagementClientContext.ts#L50

[kurtzeborn]

Thank you for opening this issue! We are routing it to the appropriate team for follow up.

[amarzavery]

That is true. As a workaround, please pass the baseUri in the options object for now, till we figure out a solution for this.

[ramya-rao-a]

@willmtemple The latest version 5.0.1 of the @azure/graph package shouldn't have this issue. If so, please close this issue

[willmtemple]

Yes, the 5.0.1 patch for the AAD Graph SDK @azure/graph fixed this issue. It was a code-generation issue that only manifested in graph when an Azure environment wasn't configured in the credential (as the issue mentioned in the original report). Setting baseUri manually should not be required as of @azure/graph 5.0.1.