Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline check to verify all dependencies with version 0.Y.Z are pinned #24833

Closed
mikeharder opened this issue Feb 10, 2023 · 1 comment
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@mikeharder
Copy link
Member

mikeharder commented Feb 10, 2023

Per semver:

  1. Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

https://semver.org/#spec-item-4

  1. A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92, 1.0.0-x-y-z.--.

https://semver.org/#spec-item-9

Additionally, the JS repo has the following guidelines:

  1. A GA package should have no runtime dependencies on packages with versions 0.Y.Z or X.Y.Z-preview. Dev dependencies on such packages are discouraged but allowed.
  2. Any dependencies, runtime or dev, on versions 0.Y.Z or X.Y.Z-preview must be pinned. Even if the dependency violations Initial commit for copying files from azure-sdk-for-node #1, it should at least be pinned.

We should add a check to our pipelines (perhaps in the "Analyze" job) to verify both guidelines. Existing violations may need to be grandfathered in, and new violations may need an exception process, but at a minimum we want to detect any new violations and have a chance to review them.

Depends on #24832

@mikeharder mikeharder added the Central-EngSys This issue is owned by the Engineering System team. label Feb 10, 2023
@ckairen ckairen moved this to 🔬Dev in PR in Azure SDK EngSys 🤖🧠 Feb 21, 2023
@ckairen ckairen moved this from 🔬Dev in PR to 🐝 Dev in Azure SDK EngSys 🤖🧠 Feb 21, 2023
@ckairen ckairen moved this from 🐝 Dev to 🔬Dev in PR in Azure SDK EngSys 🤖🧠 Feb 23, 2023
@ckairen ckairen moved this from 🔬 Dev in PR to 📋 Backlog in Azure SDK EngSys 🤖🧠 Jul 25, 2023
Copy link

Hi @mikeharder, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🤖🧠 Feb 10, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants