Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Maps Route Readme Issues #24042

Closed
zzhxiaofeng opened this issue Nov 29, 2022 · 2 comments
Closed

Azure Maps Route Readme Issues #24042

zzhxiaofeng opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Docs Maps RestLevelClient test-manual-pass

Comments

@zzhxiaofeng
Copy link
Contributor

zzhxiaofeng commented Nov 29, 2022

Section link
GetImage (35)
Reason:
Don't have package @azure-core-auth.

Suggestion:
Update to @azure/core-auth.

Section link1, link2
GetImage (36)
Reason1: Cannot redeclare block-scoped variable routeDirectionsResult and assignment to constant variable.
Reason2: summary and legs are undefined.
Reason3: legs.points and points.points are undefined.
Reason4: points.points.forEach function lacks parenthesis at the end.

Suggestion1: Update first const to let and remove the second const.
Suggestion2:
Add code as following:

const {summary, legs} = routeDirectionsResult.body.routes[0]; 

Suggestion3&4:
Update code as following:

      legs.forEach(({ summary: { travelTimeInSeconds }, points }, idx) => {  
        console.log(`${idx + 1}th leg takes ${travelTimeInSeconds} seconds to travel, and the path is: `);  
        console.log("111111111111",points);  
        points.forEach(({ latitude, longitude }, idx) =>   
        console.log(`${idx}: (${latitude}, ${longitude})`))  
      });  

Section link
GetImage (37)
Reason:
routeDirectionsResult.body.routes[0].optimizedWaypoints is undefined.

Suggestion:
Update to routeDirectionsResult.body.optimizedWaypoints

@joheredi, @markweitzel, @dw511214992 for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Docs:0.14379305,Azure.Core:0.13846812,Compute:0.059187043'

@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass Maps labels Nov 29, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 29, 2022
@xirzec xirzec assigned andykao1213 and unassigned qiaozha Nov 29, 2022
@xirzec xirzec removed the needs-team-triage Workflow: This issue needs the team to triage. label Nov 29, 2022
@andykao1213
Copy link
Member

I'm closing the issue since it has been fixed in #24064

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Docs Maps RestLevelClient test-manual-pass
Projects
None yet
Development

No branches or pull requests

7 participants