Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Communication] - short-codes - Migrate to @azure-tools/test-recorder V2 #20871

Closed
danielortega-msft opened this issue Mar 15, 2022 · 2 comments
Closed

[Communication] - short-codes - Migrate to @azure-tools/test-recorder V2 #20871

danielortega-msft opened this issue Mar 15, 2022 · 2 comments
Assignees
@danielav7
Labels
Communication - Short Codes Communication

Comments

@danielortega-msft
Copy link
Member

danielortega-msft commented Mar 15, 2022 •
edited by petrsvihlik
Loading

Migrate the communication-short-codes package tests to use the new @azure-tools/test-recorder implementation, which replaces the existing nock/nise-based recorder with a solution that uses the language-agnostic test proxy server. For more details, see: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/test-utils/recorder/MIGRATION.md.

You can also get inspired by the other ACS modalities that have already migrated.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Communication:0.3017539,Azure.Core:0.24326132,Storage:0.044237006'

@danielortega-msft danielortega-msft mentioned this issue Mar 15, 2022
Merged
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 15, 2022
@rtrevino89 rtrevino89 mentioned this issue May 26, 2022
Merged
3 tasks
@danielortega-msft
Copy link
Member Author

Resolved as of #22008

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danielav7 danielav7

Labels
Communication - Short Codes Communication
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@petrsvihlik @danielav7 @azure-sdk @danielortega-msft