Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for application insights #20828

Closed
maorleger opened this issue Mar 14, 2022 · 1 comment
Closed

Add coverage for application insights #20828

maorleger opened this issue Mar 14, 2022 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. test-enhancement

Comments

@maorleger
Copy link
Member

Consider issues that only occur when application-insights is enabled such as:

Since we do not include applicationinsights in our smoke tests, integration tests, etc. we have missed some compatibility issues leading to costly investigations from both teams.

This leads me to believe that we will benefit from adding applicationinsights to our tests. This issue tracks investigating what would be the right approach here.

A few thoughts:

  • We have a smoke test that installs all packages and runs samples or something along those lines - maybe applicationinsights should be one of the packages installed and activated?
  • I think adding this as a dependency across all packages is overkill, but maybe we can consider a few select packages like storage, identity, or even core and add some happy-path tests...
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 14, 2022
@maorleger maorleger self-assigned this Mar 14, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. Monitor - ApplicationInsights needs-team-triage Workflow: This issue needs the team to triage. labels Mar 14, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 14, 2022
@maorleger maorleger added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed Monitor - ApplicationInsights needs-team-triage Workflow: This issue needs the team to triage. labels Mar 14, 2022
@azure-sdk azure-sdk added Monitor - ApplicationInsights needs-team-triage Workflow: This issue needs the team to triage. labels Mar 14, 2022
@maorleger maorleger added test-enhancement and removed Monitor - ApplicationInsights needs-team-triage Workflow: This issue needs the team to triage. labels Mar 14, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 14, 2022
@maorleger maorleger added this to the Backlog milestone Mar 14, 2022
@xirzec xirzec assigned mpodwysocki and unassigned maorleger Jun 6, 2022
Copy link

Hi @maorleger, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. test-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants