Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Purview Catalog Sample Issue #18877

Closed
v-jiaodi opened this issue Nov 30, 2021 · 2 comments · Fixed by #20391
Closed

Azure Purview Catalog Sample Issue #18877

v-jiaodi opened this issue Nov 30, 2021 · 2 comments · Fixed by #20391
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool Docs Purview test-manual-pass
Milestone

Comments

@v-jiaodi
Copy link
Member

Section link:

image

Reason:
PurviewCatalog is not a function

Suggestion:
Update PurviewCatalog to { default:PurviewCatalog }

@ramya-rao-a , @mikekistler, @lmazuel and @qiaozha for notification.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 30, 2021
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Purview test-manual-pass and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 30, 2021
@ramya-rao-a ramya-rao-a added this to the [2022] January milestone Nov 30, 2021
@ramya-rao-a ramya-rao-a added Docs and removed needs-team-triage Workflow: This issue needs the team to triage. labels Nov 30, 2021
@joheredi joheredi assigned qiaozha and unassigned joheredi Nov 30, 2021
@joheredi
Copy link
Member

The root cause of this is the same as #18878. Where the samples generator doesn't know how to convert default exports. #18878 describes a possible solution for the root cause.

Once the samples generator can handle default imports we need to regenerate the samples. Assigning to @qiaozha to re-generate once the dev-tool is updated

@witemple-msft
Copy link
Member

@qiaozha The latest dev-tool changes have a fix for the default import. It is still required to change instances of ?. and ?? to syntax that is compatible with Node 12 in order to generate the samples (until Node 12 support is dropped in November).

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. dev-tool Issues related to the Azure SDK for JS dev-tool Docs Purview test-manual-pass
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants