Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip running tests if only samples or markdown files have changed #18465

Closed
ramya-rao-a opened this issue Nov 1, 2021 · 2 comments
Closed

Skip running tests if only samples or markdown files have changed #18465

ramya-rao-a opened this issue Nov 1, 2021 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@ramya-rao-a
Copy link
Contributor

We logged Azure/azure-sdk-tools#1667 to allow skipping of running build or tests in PRs when the only changes are in the markdown files. This issue is an extension of that but in the context of file changes under the samples folder.

For example, see #18463 where all we did was update samples. While building the source code and running the samples related scripts are useful, running the actual tests is not

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 1, 2021
@ramya-rao-a ramya-rao-a added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 1, 2021
@kurtzeborn
Copy link
Member

This should be done in all of our language repos, not jus the JS repo.

The reason we haven't supported this is because DevOps doesn't really support it. @benbp has suggested that adding a feature to support this in the test matrix generation scripts might be a possible way to tackle this.

Related question is whether GitHub actions supports this (something we'll be investigating more over the next 6 months).

@kurtzeborn
Copy link
Member

Looking at the issue you linked to Azure/azure-sdk-tools#1667, that one is already tracking solving this generally. I'm going to go ahead and close this one since we don't want to implement a JS only solution for this. We want to do this with all of the language repos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

3 participants