Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] - importKey will currently ignore key_ops #18294

Closed
maorleger opened this issue Oct 20, 2021 · 1 comment
Closed

[KeyVault] - importKey will currently ignore key_ops #18294

maorleger opened this issue Oct 20, 2021 · 1 comment
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] November

Comments

@maorleger
Copy link
Member

When deprecating keyOps in favor of key_ops I forgot about BYOK (aka importKey)... in this case the transformations we apply do not run as JsonWebKey is exported directly from generated code.

If a customer provides key_ops we should prefer key_ops. Otherwise take keyOps

Ideally this would be a swagger transformation that preserves the snake_case...
@maorleger maorleger added this to the [2021] November milestone Oct 20, 2021
@maorleger maorleger self-assigned this Oct 20, 2021
@maorleger maorleger mentioned this issue Oct 21, 2021
Closed
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 21, 2021
@maorleger
Copy link
Member Author

As we reverted the key_ops rename for now this is not pertinent anymore

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] November
Development

Successfully merging a pull request may close this issue.

[KeyVault] - Ensure keyOps is used when importing a key maorleger/azure-sdk-for-js
2 participants
@maorleger @ramya-rao-a