Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename query APIs in Logs and Metrics Client #17852

Closed
srnagar opened this issue Sep 24, 2021 · 3 comments
Closed

Rename query APIs in Logs and Metrics Client #17852

srnagar opened this issue Sep 24, 2021 · 3 comments
Assignees
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query

Comments

@srnagar
Copy link
Member

srnagar commented Sep 24, 2021

To prepare for supporting resource-centric logs queries, make the following name changes to the query APIs in Logs and Metrics clients.

LogsQueryClient

queryWorkspace(workspaceId: string, query: string, timespan: TimeInterval, options?: LogsQueryOptions): Promise<LogsQueryResult>;

MetricsQueryClient

queryWorkspace(resourceUri: string, metricNames: string[], options?: MetricsQueryOptions): Promise<MetricsQueryResult>;
@KarishmaGhiya
Copy link
Member

@srnagar isn't that TimeInterval supposed to be renamed to QueryTimeInterval?

@rakshith91
Copy link

@srnagar isn't that TimeInterval supposed to be renamed to QueryTimeInterval?

https://apiview.dev/Assemblies/Review/6a68e77d395046a8a0df8621ef3f07b7#com.azure.monitor.query.models.QueryTimeInterval

looks like java changed it to QueryTimeInterval

@KarishmaGhiya
Copy link
Member

Addressed in PR - #17873

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

No branches or pull requests

4 participants