Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search-documents tests to handle sovereign cloud endpoints dynamically #17577

Closed
benbp opened this issue Sep 10, 2021 · 1 comment
Closed

Update search-documents tests to handle sovereign cloud endpoints dynamically #17577

benbp opened this issue Sep 10, 2021 · 1 comment
Assignees
@sarangan12
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2022] February

Comments

@benbp
Copy link
Member

benbp commented Sep 10, 2021 •
edited
Loading

See related discussion and links for guidance and examples of how to fix this: #17443 (review)

The search-documents tests currently use a switch statement to override endpoint values. This should instead be sourced from dynamic output values in the ARM template.

CC @ramya-rao-a @sarangan12
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 10, 2021
@benbp benbp mentioned this issue Sep 10, 2021
Merged
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Search labels Sep 10, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 10, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] November milestone Sep 10, 2021
@sarangan12 sarangan12 mentioned this issue Jan 11, 2022
Merged
@sarangan12
Copy link
Contributor

Code complete with PR #19781

This was referenced Jan 25, 2022
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarangan12 sarangan12

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2022] February
Development

No branches or pull requests
3 participants
@sarangan12 @benbp @ramya-rao-a