Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ]Enable MSAL log and MSAL PII Logs #17281

Closed
g2vinay opened this issue Aug 26, 2021 · 4 comments
Closed

[FEATURE REQ]Enable MSAL log and MSAL PII Logs #17281

g2vinay opened this issue Aug 26, 2021 · 4 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@g2vinay
Copy link
Member

g2vinay commented Aug 26, 2021

Library or service name.
Azure.Identity

Is your feature request related to a problem? Please describe.
Azure.Identity should allow customers to configure MSAL logging levels, including PII info and platform loggings.

Enable MSAL Logging: Port the implementation from this PR
Enable PII Logs: Port the implementation from this PR

@g2vinay g2vinay added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Aug 26, 2021
@sadasant sadasant added this to the [2021] September milestone Aug 26, 2021
@sadasant
Copy link
Contributor

Note to self: .NET adds it on TokenCredentialOptions

@sadasant
Copy link
Contributor

Regarding “Enable MSAL Logging”, we already have this enabled!

All of our MSAL clients get configured with logging, as you can see here: https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/src/msal/utils.ts#L86-L110

This has been true for a while.

So, I’ll focus on PII 🤔

@sadasant
Copy link
Contributor

sadasant commented Sep 2, 2021

After our last meeting (today Thursday Sep 2, with the architects across languages), I’m moving this to the next milestone.

@sadasant
Copy link
Contributor

sadasant commented Sep 7, 2021

We’ve decided to close this for now, since currently there’s no use case for these logs on JS.

@sadasant sadasant closed this as completed Sep 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants