Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[check-node-versions] Fails in 5 different ways #16661

Closed
HarshaNalluru opened this issue Jul 29, 2021 · 7 comments
Closed

[check-node-versions] Fails in 5 different ways #16661

HarshaNalluru opened this issue Jul 29, 2021 · 7 comments
Assignees
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool EngSys This issue is impacting the engineering system.
Milestone

Comments

@HarshaNalluru
Copy link
Member

I was releasing app-config and hit all sorts of errors with check-node-versions.

  1. Codespaces
    npx dev-tool samples check-node-versions --artifact-path https://bit.ly/2Vj9AEo --node-versions "14,16" is my command
    image

  2. I gave up and started using the dev-tool in my local.
    image

  3. I tried deleting them with the container ids and it says they are not found. Tried again, this time it goes past that step and hits a new issue.
    image

  4. Samples generation also seem to have a problem.
    We are generating and publishing and never cared about running them. @witemple-msft
    image

  5. I don't even understand what I should be doing.
    I did give the artifact URL, I don;t know why it still fails.
    image

Dev-tool with the check-node-versions used to sweetly run all the samples at once before, I just want to get that behavior back! 😥

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 29, 2021
@ramya-rao-a ramya-rao-a added dev-tool Issues related to the Azure SDK for JS dev-tool EngSys This issue is impacting the engineering system. labels Jul 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 30, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] August milestone Jul 30, 2021
@deyaaeldeen
Copy link
Member

@HarshaNalluru I just found out that installing packages from URLs provided by the release pipeline does not actually work! because they're not direct links. See https://teams.microsoft.com/l/message/19:[email protected]/1627675696540?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1627675696540&teamName=Azure%20SDK&channelName=Engineering%20System%20%F0%9F%9B%A0%EF%B8%8F&createdTime=1627675696540. Could you try download the artifact first and then use the local path in the --artifact-path argument? I just tested on linux and it works fine.

@deyaaeldeen
Copy link
Member

Ok, I also tested it on windows and it works fine for me:
checkNodeVersions

I suspect something went bad with your docker some reason but I can not reproduce what you saw. Although it works for me on windows, could you try on linux instead?

@deyaaeldeen
Copy link
Member

Actually, there is a bug I just fixed in #16686 and I think that was responsible for issue at step 3. Let's try again after that PR gets merged.

@deyaaeldeen deyaaeldeen added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Aug 2, 2021
@ghost
Copy link

ghost commented Aug 2, 2021

Hi @HarshaNalluru. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@HarshaNalluru HarshaNalluru removed the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Aug 3, 2021
@HarshaNalluru
Copy link
Member Author

I can create individual issues for the rest and close this if you want @deyaaeldeen

@HarshaNalluru
Copy link
Member Author

Closing in favor of #16713

@HarshaNalluru
Copy link
Member Author

#15619 tracks 1

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants