Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-rest-pipeline] Throttling retry policy should account for abortSignal #16118

Closed
HarshaNalluru opened this issue Jun 30, 2021 · 2 comments
Closed
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Jun 30, 2021

Problem

The throttlingRetryPolicy in core-http has the potential to retry for an extended period if the service continues returning "retry after" headers on subsequent calls.

Here's the snippet of code that handles the "retry after" retries:

image

TODO

@xirzec

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 30, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 1, 2021
@chradek chradek added the Client This issue points to a problem in the data-plane of the library. label Jul 1, 2021
@chradek chradek added this to the [2021] August milestone Jul 1, 2021
@HarshaNalluru HarshaNalluru modified the milestones: Backlog, [2022] April Mar 14, 2022
@HarshaNalluru
Copy link
Member Author

Handling as part of #20781 and #20766

@HarshaNalluru
Copy link
Member Author

#20781 merged

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

2 participants