Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Identity version in attestation package to 2.0.0-beta.4 #15759

Closed
KarishmaGhiya opened this issue Jun 16, 2021 · 6 comments · Fixed by #16438
Closed

Update Identity version in attestation package to 2.0.0-beta.4 #15759

KarishmaGhiya opened this issue Jun 16, 2021 · 6 comments · Fixed by #16438
Assignees
Labels
Attestation Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Jun 16, 2021

Update identity to 2.0.0-beta.4 for @azure/attestation

Related epic - #14581

Instructions:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 16, 2021
@KarishmaGhiya KarishmaGhiya added Client This issue points to a problem in the data-plane of the library. Attestation labels Jun 16, 2021
@KarishmaGhiya KarishmaGhiya added this to the [2021] July milestone Jun 16, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 16, 2021
@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Jun 16, 2021

You can use this PR as reference for attestation package - #15717

@LarryOsterman
Copy link
Member

@KarishmaGhiya Playback is failing after updating recordings:

 CredentialUnavailableError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://login.microsoftonline.com/12345678-1234-1234-1234-1234567890ab/v2.0/.well-known/openid-configuration

Your instructions said "one like 1234...123456789012". I suspect that it must be 1234....123456789012, because 1234567890AB failed.

@HarshaNalluru
Copy link
Member

Your instructions said "one like 1234...123456789012". I suspect that it must be 1234....123456789012, because 1234567890AB failed.

More info: msal library checks for the ids and would fail if it doesn't like the syntax.

@KarishmaGhiya
Copy link
Member Author

@LarryOsterman msal library needs those to be just numbers not characters in the above format.

@LarryOsterman
Copy link
Member

@LarryOsterman msal library needs those to be just numbers not characters in the above format.

This is REALLY confusing then. AZURE_TENANT_ID is a GUID, not an array of numbers. But the replacement string needs to be a set of numbers, not a GUID?

Is that intentional? If so, why??

@HarshaNalluru
Copy link
Member

I believe msal expects tenant-id to be in that format. Do you have any specifics, @sadasant?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Attestation Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants