Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACR] Incorporate API review feedback from Arch Board #15203

Closed
7 of 9 tasks
annelo-msft opened this issue May 10, 2021 · 3 comments
Closed
7 of 9 tasks

[ACR] Incorporate API review feedback from Arch Board #15203

annelo-msft opened this issue May 10, 2021 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone
[2021] July

Comments

@annelo-msft
Copy link
Member

annelo-msft commented May 10, 2021 •
edited by jeremymeng
Loading

  • Rename GetTagProperties to GetTag (or language appropriate)
  • Remove LoginServer and Name properties from ContainerRegistryClient
  • Come up with better name for ArtifactManifestReference
  • Remove the DeleteRepositoryResult type, and return a success result from DeleteRepository operation even when a 404 is received.
  • Evaluate FullyQualifiedName with regard to 1) what we do in other Track 2 libraries wrt to the qualified name concept and 2) what this is commonly called in the Docker/containers community.
  • Replace TagOrDigest with Digest.
  • Ensure functional parity of Python library with others
  • Rename PATCH service methods from Set.. to Update..
  • Discuss parallelizing the delete sample across languages
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels May 10, 2021
@annelo-msft annelo-msft added this to the [2021] July milestone May 10, 2021
@annelo-msft
Copy link
Member Author

@jeremymeng, would you add JS/TS-specific items from arch board to this issue?

@jeremymeng
Copy link
Member

@jeremymeng, would you add JS/TS-specific items from arch board to this issue?

Sure! Thanks @annelo-msft

@jeremymeng jeremymeng mentioned this issue May 27, 2021
Closed
@jeremymeng
Copy link
Member

delete sample update is now tracked by #15792

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
2 participants
@jeremymeng @annelo-msft