Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateOctKeyOptions required keySize parameter #13545

Closed
heaths opened this issue Feb 2, 2021 · 1 comment
Closed

CreateOctKeyOptions required keySize parameter #13545

heaths opened this issue Feb 2, 2021 · 1 comment
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] February

Comments

@heaths
Copy link
Member

heaths commented Feb 2, 2021

What about keySize here? That's valid as well. See https://github.com/Azure/azure-sdk-for-net/blob/f8aabfa3cc1b0a7ae2b6a1c111ea96416b3a4f4d/sdk/keyvault/Azure.Security.KeyVault.Keys/src/CreateOctKeyOptions.cs#L27. In .NET we have optional "parameters" as read-write properties instead of constructor params (reserved for required "parameters" and their properties are typically read-only).

Originally posted by @heaths in #13522 (comment)
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 2, 2021
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Feb 2, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 2, 2021
@heaths heaths added this to the [2021] February milestone Feb 2, 2021
@heaths heaths mentioned this issue Feb 2, 2021
Merged
@maorleger
Copy link
Member

As per our discussion keySize is supported for createOctKey. Going to close this issue and open a backlog item to tackle the tech debt of the duplication (which led to the confusion).

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] February
Development

No branches or pull requests
2 participants
@maorleger @heaths