[ESLint Plugin] Some of the tests behavior changed after TS upgrade

[deyaaeldeen]

ts-use-promises changed its behavior after upgrading TS to v4.1.2 causing a unit test to fail:

Detailed error

  1 failing
  1) ts-use-promises
       invalid
         import Promise from 'bluebird';
const promise = (): Promise<string> => {
    return new Promise(resolve => resolve("example"));
}
:

      AssertionError [ERR_ASSERTION]: Should have 1 error but had 0: []
      + expected - actual

      -0
      +1

      at testInvalidTemplate (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/rule-tester/rule-tester.js:666:24)
      at Context.<anonymous> (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/rule-tester/rule-tester.js:893:25)
      at callFn (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:374:21)
      at Test.Runnable.run (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runnable.js:361:7)
      at Runner.runTest (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:619:10)
      at /mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:745:12
      at next (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:536:14)
      at /mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:546:7
      at next (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:448:14)
      at Immediate._onImmediate (/mnt/vss-agent-2.179.0/_work/1/s/common/temp/node_modules/.pnpm/[email protected]/node_modules/mocha/lib/runner.js:514:5)
      at processImmediate (internal/timers.js:461:21)

Code pointers for anyone wanting to fix this:

• Set up your dev env if you have not already
• ESLint Plugin source code

[ramya-rao-a]

I don't see the above test failing anymore, but I see a different one failing:

  1143 passing (8m)
  1 failing

  1) plugin
       rules
         the number of rules should match the expected value:

      AssertionError: expected 46 to equal 47
      + expected - actual

      -46
      +47

      at Context.<anonymous> (C:\GitRepos\azure-sdk-for-js\common\tools\eslint-plugin-azure-sdk\tests\plugin.ts:157:14)
      at callFn (C:\GitRepos\azure-sdk-for-js\common\temp\node_modules\.pnpm\[email protected]\node_modules\mocha\lib\runnable.js:374:21)

[deyaaeldeen]

@ramya-rao-a the test mentioned in the description is currently commented out:

azure-sdk-for-js/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-use-promises.ts

Lines 46 to 55 in d515f86

	// this could should be uncommented after this issue has been fixed:
	// https://github.com/Azure/azure-sdk-for-js/issues/13186
	// {
	// code: `import Promise from 'bluebird';${example}`,
	// errors: [
	// {
	// message: "promises should use the in-built Promise type, not libraries or polyfills"
	// }
	// ]
	// }

[maorleger]

to @ramya-rao-a 's comment looks like "ts-package-json-sdktype", is duplicated in the ruleList. I can open a PR to fix that shortly, but I agree we should run these rules as part of CI when plugin code changes...

Edit to add: and maybe lint all the packages if any eslint plugin code changes. Haven't thought this through though...

[ramya-rao-a]

maybe lint all the packages if any eslint plugin code changes. Haven't thought this through though...

We already have that :) See the latest on this at #18770

[github-actions]

Hi @deyaaeldeen, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.