Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Upgrade to MSAL 2.0 #13155

Closed
sadasant opened this issue Jan 11, 2021 · 3 comments · Fixed by #13263
Closed

[Identity] Upgrade to MSAL 2.0 #13155

sadasant opened this issue Jan 11, 2021 · 3 comments · Fixed by #13263
Assignees
@sadasant
Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] March

Comments

@sadasant
Copy link
Contributor

Make use of msal-browser 2.0 on the browser-friendly credentials. At least on the Interactive Browser Credential.

Where to find msal-browser 2.0: link.
@sadasant sadasant added this to the [2021] February milestone Jan 11, 2021
@sadasant sadasant self-assigned this Jan 11, 2021
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jan 12, 2021
@chradek
Copy link
Contributor

chradek commented Jan 12, 2021

Just curious, will we continue to support implicit grant flow for logins or also/only support Authorization Code Flow with PKCE when upgrading to msal 2.0?

@ramya-rao-a ramya-rao-a mentioned this issue Jan 12, 2021
Merged
@sadasant
Copy link
Contributor Author

@chradek I don't think so. I've been asking about the same. Let me reach out to you.

@sadasant
Copy link
Contributor Author

@chradek based on the conversation we had, it should be ok to move to PKCE. I will make sure an app that has already been enabled to work with the implicit flow can still work with the PKCE update 👍

This was referenced Jan 15, 2021
Merged
Closed
@sadasant sadasant added the blocking-release Blocks release label Jan 25, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Jan 29, 2021
Closed
3 tasks
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Mar 12, 2021
@stehou
CodeGen from PR 13155 in Azure/azure-rest-api-specs
3b9ec9e 
Microsoft.Compute: Add new stable API version 2021-03-01 for CloudServices resource (Azure#13155)

* add previous cloud service version

* add 2021-03-01 version

* add rdp response body

* update examples

* suppress error

* try suppress

* suppress

* remove example and suppress error

* add new optional allowModelOverride property

* update custom words

Co-authored-by: stephenhou <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity blocking-release Blocks release Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] March
Development

Successfully merging a pull request may close this issue.

[Identity] InteractiveBrowserCredential to use MSAL Browser 2.0 sadasant/azure-sdk-for-js
3 participants
@sadasant @ramya-rao-a @chradek