Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] AAD support #13142

Closed
jeremymeng opened this issue Jan 11, 2021 · 0 comments · Fixed by #13170
Closed

[MetricsAdvisor] AAD support #13142

jeremymeng opened this issue Jan 11, 2021 · 0 comments · Fixed by #13170
Assignees
@KarishmaGhiya
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] February

Comments

@jeremymeng
Copy link
Member

Add back AAD support and a couple tests.

For reference, the support was removed in this commit (private repo): https://github.com/Azure/azure-sdk-for-js-pr/commit/9c705cf0ca1d7873c4da700b07519661d956c320#diff-84db8606813e152afa117831ef8f3a8722bdc0c50cb475d6c655c922c90334a4
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Jan 11, 2021
@jeremymeng jeremymeng added this to the [2021] February milestone Jan 11, 2021
@jeremymeng jeremymeng mentioned this issue Jan 14, 2021
Closed
@KarishmaGhiya KarishmaGhiya linked a pull request Jan 20, 2021 that will close this issue
[Metrics Advisor] AAD Support #13170
Merged
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KarishmaGhiya KarishmaGhiya

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] February
Development

Successfully merging a pull request may close this issue.

[Metrics Advisor] AAD Support KarishmaGhiya/azure-sdk-for-js
2 participants
@jeremymeng @KarishmaGhiya