Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can developers install a single package directly from Git/GitHub? #12853

Closed
1 task done
jmealo opened this issue Dec 10, 2020 · 7 comments · Fixed by #12843
Closed
1 task done

How can developers install a single package directly from Git/GitHub? #12853

jmealo opened this issue Dec 10, 2020 · 7 comments · Fixed by #12843
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@jmealo
Copy link

jmealo commented Dec 10, 2020

  • Package Name:
    @azure/monitor-opentelemetry-exporter / @microsoft/opentelemetry-exporter-azure-monitor
  • Package Version:
    All
  • Operating system:
  • nodejs

Describe the bug
The versions published to NPM lag behind GitHub. Typically developers will install a particular branch directly from GitHub. Every example of how to install a package from Git/GitHub assumes that package.json is in the root of the repository. However, because the this is a mono-repo, the notation or support for doing such is unclear. If this is possible, outlining it in the README.md of the repo would be helpful.

To Reproduce
Steps to reproduce the behavior:
1.Want to apply the latest break fixes

Expected behavior

  1. Deploy from NPM (preferred)
  2. Deploy from GitHub (documented fallback)

Discussion of adding this feature to NPM:
npm/npm#2974

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 10, 2020
@jmealo
Copy link
Author

jmealo commented Dec 10, 2020

I built @microsoft/opentelemetry-exporter-azure-monitor package from the default branch after cloning and was able to use rush and the included npm scripts to build and pack a .tgz, which upon installing, had a different public interface than the previously published module.

@jeremymeng
Copy link
Member

Note that we also publish nightly alpha builds to npm

@jmealo
Copy link
Author

jmealo commented Dec 10, 2020

@jeremymeng: https://www.npmjs.com/package/@azure/monitor-opentelemetry-exporter Last alpha was published a month ago.

@jeremymeng
Copy link
Member

@jmealo you are right. Most likely due to the renaming of the package, we haven't been publishing the package under the new name.

@xirzec
Copy link
Member

xirzec commented Dec 11, 2020

I'm working on fixing this in #12843 which was blocked on some CI trouble that I believe is now resolved. Putting the package back into @azure should resolve the trouble with nightlies.

@xirzec xirzec added the EngSys This issue is impacting the engineering system. label Dec 11, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 11, 2020
@xirzec xirzec self-assigned this Dec 11, 2020
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 11, 2020
@jmealo
Copy link
Author

jmealo commented Dec 11, 2020

@xirzec: I'm not sure when the alphas are due to be built, but nothing was published last night, so I don't know if this has been resolved. Either way, that release will be unusable for anyone who set their backend role manually as instructed.

@xirzec
Copy link
Member

xirzec commented Dec 11, 2020

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. EngSys This issue is impacting the engineering system. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants