Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use DataLakePathClient to do things with the root path #12813

Closed
1 of 6 tasks
MRayermannMSFT opened this issue Dec 8, 2020 · 2 comments · Fixed by #12890
Closed
1 of 6 tasks

Cannot use DataLakePathClient to do things with the root path #12813

MRayermannMSFT opened this issue Dec 8, 2020 · 2 comments · Fixed by #12890
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)

Comments

@MRayermannMSFT
Copy link

MRayermannMSFT commented Dec 8, 2020

  • Package Name: @azure/storage-file-datalake
  • Package Version: 12.2.0
  • Operating system: any
  • nodejs
    • version: 12
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
If I create a DataLakePathClient with a URL like https://accountname.dfs.core.windows.net/containername/somefolder then things work as expected. But, if I try to use a URL that points to the root path, such as either:

  • https://accountname.dfs.core.windows.net/containername/ (this one I would most expect to work)
  • https://accountname.dfs.core.windows.net/containername (this one seems to point more to the container, I'm ok if it doesn't work)

then the SDK throws the following error:

message:'Unable to extract blobName and containerName with provided information.'

which appears to originate from here:

image

because blobName is an empty string.

If I debug into the SDK and avoid the error by temporarily changing the parsed blobName to be something not empty string before the if check, and then back to empty string after the if check, then things work as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Create a DataLakePathClient which points to the root directory.

Expected behavior
The root is a valid path, so I should be able to use a path client with it.

Screenshots
N/A

Additional context
N/A

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 8, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Dec 8, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 8, 2020
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Dec 8, 2020
@ljian3377 ljian3377 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Dec 9, 2020
@ljian3377 ljian3377 added this to the [2021] January milestone Dec 9, 2020
@ljian3377
Copy link
Member

ljian3377 commented Dec 9, 2020

Yes, this is a bug.

Need to find out what's the right blobName for a root path. We should allow empty blobName as long as it works with the SAS logic.

@ljian3377 ljian3377 removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 9, 2020
@MRayermannMSFT
Copy link
Author

Thanks for the fast resolution @ljian3377 !

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants