Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] rename listDimensionValuesForDetectionConfig() #12348

Closed
3 tasks
jeremymeng opened this issue Nov 6, 2020 · 0 comments · Fixed by #13486
Closed
3 tasks

[MetricsAdvisor] rename listDimensionValuesForDetectionConfig() #12348

jeremymeng opened this issue Nov 6, 2020 · 0 comments · Fixed by #13486
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Nov 6, 2020 •
edited
Loading

We still need to align on the name for this method.

  • rename
  • add usage into sample
  • update/fix doc comments - it's missing a @param for dimensionName
    Not sure which file is the best place. incidentsAndAlerts maybe, since this method should have been called listAnomalyDimensionValues() or similar.
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Nov 6, 2020
@jeremymeng jeremymeng added this to the Backlog milestone Nov 6, 2020
@jeremymeng jeremymeng changed the title [MetricsAdvisor] update sample to show listDimensionValuesForDetectionConfig() usage [MetricsAdvisor] rename listDimensionValuesForDetectionConfig() Nov 7, 2020
@jeremymeng jeremymeng mentioned this issue Jan 14, 2021
Closed
@KarishmaGhiya KarishmaGhiya linked a pull request Jan 29, 2021 that will close this issue
[metrics advisor] updated method name for listDimensionValuesForDetectionConfig() #13486
Merged
@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
2 participants
@xirzec @jeremymeng