Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage-file-datalake] unexpected behavior with copysource including special char #11849

Closed
ljian3377 opened this issue Oct 15, 2020 · 1 comment · Fixed by #11950
Closed

[storage-file-datalake] unexpected behavior with copysource including special char #11849

ljian3377 opened this issue Oct 15, 2020 · 1 comment · Fixed by #11950
Assignees
@XiaoningLiu @jeremymeng @ljian3377
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@ljian3377
Copy link
Member

ljian3377 commented Oct 15, 2020 •
edited
Loading

Should url encode the copysource. Would fail when

"x-ms-rename-source": {
          "name": "x-ms-rename-source",
          "value": "/abc/New Text Document3.txt"
},
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 15, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 15, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 15, 2020
@jeremymeng
Copy link
Member

We are applying the heuristic strategy one mentioned https://github.com/Azure/azure-storage-js/blob/e6fe50e3a5f3e15026587ed4d56e5e14a6a0662c/file/lib/utils/utils.common.ts#L46. I believe it's the same cross all storage libraries.

@ljian3377 ljian3377 changed the title [storage-file-datalake] unexpected behavior with blob name include special char [storage-file-datalake] unexpected behavior with copysource including special char Oct 16, 2020
@ljian3377 ljian3377 mentioned this issue Oct 20, 2020
Merged
@ljian3377 ljian3377 mentioned this issue Oct 27, 2020
Closed
@JasonYeMSFT JasonYeMSFT mentioned this issue Nov 11, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@XiaoningLiu XiaoningLiu

@jeremymeng jeremymeng

@ljian3377 ljian3377

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[storage-file-datalake] encode move source ljian3377/azure-sdk-for-js
4 participants
@XiaoningLiu @jeremymeng @ljian3377 @ramya-rao-a