Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Identity e2e tests for running in Azure Service Fabric #11725

Closed
joshfree opened this issue Oct 8, 2020 · 6 comments
Closed

Create Identity e2e tests for running in Azure Service Fabric #11725

joshfree opened this issue Oct 8, 2020 · 6 comments
Assignees
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. test-enhancement

Comments

@joshfree
Copy link
Member

joshfree commented Oct 8, 2020

Tracking item to create new /sdk/e2e Azure.Identity smoke tests for running in Azure Service Fabric hosted environment.

  1. Add new /sdk/e2e tests for Azure Service Fabric
  2. Update Parent issue Automate Azure Service Fabric testing azure-sdk#901 with instructions for Test team

Python has some instructions already merged - Azure/azure-sdk#901 (comment)
Referencing Python's PR with latest updates - Azure/azure-sdk-for-python#21370

@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Azure.Identity test enhancement labels Oct 8, 2020
@joshfree joshfree added this to the [2020] November milestone Oct 8, 2020
@sophiajt sophiajt modified the milestones: [2020] November, MQ-2020 Oct 29, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, [2021] February Nov 16, 2020
@sadasant
Copy link
Contributor

Moved to March. Time is getting short on February.

@sadasant
Copy link
Contributor

@KarishmaGhiya So, in summary, this issue is about:

  • Manually test Identity (DefaultAzureCredential and ManagedIdentityCredential) in Azure Service Fabric.
  • Write clear instructions on how to create the resource, deploy some testing code, and run the testing code.
  • Put the code and instructions in tests/e2e/azure-service-fabric.
    • There should be a README.md, sample code and a package json.

I wrote some instructions for Azure Arc a while ago. Those should work as a reference: Azure/azure-sdk#1908 (comment)

You can also look at what Python has done: https://github.com/mccoyp/azure-sdk-for-python/tree/master/sdk/identity/azure-identity/tests/managed-identity-live

Java has something more automated, but in case it helps: https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/e2e/src

Regarding how to make these resources:
Other languages have already made resources where to run these manual tests. Reach out to either McCoy Patiño, Catalina Peralta or Vinay Gera for more information.

@sadasant
Copy link
Contributor

Small update: we already have a folder, test/manual-integration. Let's use that one for now!

@sadasant sadasant modified the milestones: [2021] May, [2021] June May 11, 2021
@sadasant sadasant modified the milestones: [2021] June, [2021] July Jun 15, 2021
@sadasant sadasant removed their assignment Jun 16, 2021
@KarishmaGhiya KarishmaGhiya linked a pull request Jul 4, 2021 that will close this issue
@sadasant sadasant removed this from the [2021] August milestone Jul 20, 2021
@sadasant sadasant added this to the [2021] September milestone Jul 20, 2021
@sadasant
Copy link
Contributor

sadasant commented Jul 20, 2021

Moved to September as this issue needs Service Fabric support to be added back first #12420

@sadasant
Copy link
Contributor

It won’t be possible for us to finish the e2e service fabric guide for JavaScript yet because the Python guide is not currently working as expected. Once Python’s guide is updated, we will continue to work on the e2e guide for JavaScript.

@sadasant sadasant modified the milestones: [2021] December, Backlog Oct 21, 2021
Copy link

Hi @joshfree, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. test-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants