Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse generated files in review #11376

Closed
xirzec opened this issue Sep 21, 2020 · 4 comments · Fixed by #17139
Closed

Collapse generated files in review #11376

xirzec opened this issue Sep 21, 2020 · 4 comments · Fixed by #17139
Labels
Client This issue points to a problem in the data-plane of the library. good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@xirzec
Copy link
Member

xirzec commented Sep 21, 2020

GitHub has support via .gitattributes to treat generated files as do-not-display-by-default in PRs:

https://docs.github.com/en/github/administering-a-repository/customizing-how-changed-files-appear-on-github

It also avoids them counting towards language metrics on the repo, which is neat.

We should do this for all recordings + AutoRest.TypeScript generated code.
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Sep 21, 2020
@xirzec xirzec added this to the MQ-2020 milestone Sep 21, 2020
@HarshaNalluru
Copy link
Member

HarshaNalluru commented Sep 21, 2020 •
edited
Loading

We do this for the recordings already.
image

@ramya-rao-a
Copy link
Contributor

So, are we saying that all that is pending to do is to add the below?

# Mark generated code as auto generated
**/generated/**/*.ts linguist-generated=true

@HarshaNalluru
Copy link
Member

That should be enough @ramya-rao-a

@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated good first issue This issue tracks work that may be a good starting point for a first-time contributor labels Feb 2, 2021
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, Backlog Feb 2, 2021
@govardhan27
Copy link
Contributor

govardhan27 commented Aug 26, 2021 •
edited
Loading

Hey guys,
I have done the required changes as suggested above, can you look at this PR #17139 ?

@HarshaNalluru HarshaNalluru mentioned this issue Aug 26, 2021
Merged
@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added github support via .gitattributes to treat generated files in P…
4 participants
@xirzec @HarshaNalluru @ramya-rao-a @govardhan27