Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Move Challenge-Based Authentication to core #11225

Closed
sophiajt opened this issue Sep 13, 2020 · 2 comments · Fixed by #11226
Closed

[Identity] Move Challenge-Based Authentication to core #11225

sophiajt opened this issue Sep 13, 2020 · 2 comments · Fixed by #11226
Assignees
@sophiajt
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] October

Comments

@sophiajt
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, KeyVault holds a copy of challenge-based auth as it was the only known consumer. Now, more services are beginning to use this method.

Describe the solution you'd like
Centralize challenge-based auth so that more parts of the SDK can use it.

Describe alternatives you've considered
There are a couple places we might put it: the identity package or core. Putting it in core makes it more centralized and doesn't pull in the added requirements of identity.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2020
@sophiajt sophiajt self-assigned this Sep 13, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 13, 2020
@sophiajt sophiajt mentioned this issue Sep 13, 2020
Merged
@sophiajt sophiajt added this to the [2020] October milestone Sep 14, 2020
@ramya-rao-a
Copy link
Contributor

@jonathandturner, Can you share which services are needing the challenge based auth apart from Key Vault at the moment?

@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Sep 14, 2020
@sophiajt
Copy link
Contributor Author

@schaabs do you know offhand which services are switching to challenge-based auth?

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sophiajt sophiajt

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] October
Development

Successfully merging a pull request may close this issue.

[core-http] Move challenge based auth to core-http sophiajt/azure-sdk-for-js
2 participants
@sophiajt @ramya-rao-a