Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support key export from Key Vault #11029

Closed
6 tasks
heaths opened this issue Sep 4, 2020 · 8 comments
Closed
6 tasks

Support key export from Key Vault #11029

heaths opened this issue Sep 4, 2020 · 8 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020

For Key Vault 7.2-preview, we need to add support to export keys. This would be a method like KeyClient.ExportKey that takes the key name, key version (both required), and a body with the KeyExportParameters model found in the link below. This only has a single required property named environment (model property: env), so we should take this as a parameter. This returns a KeyVaultKey (model KeyBundle).

This requires a number of other changes:

  • Add optional Exportable boolean property to KeyProperties.
  • Add ReleasePolicy property to KeyProperties of type KeyReleasePolicy.
  • Add PublicExponent integer property to CreateKeyOptions.
  • Add "export" to KeyOperation enum. This will correctly impact the CreateKeyOptions class and the KeyClient.UpdateKey method..
  • Add ReleasePolicy property to CreateKeyOptions.
  • Add ReleasePolicy property to ImportKeyOptions.

See the service version 7.1 -> 7.2-preview diff 🔒 for details.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@ramya-rao-a ramya-rao-a added the blocking-release Blocks release label Sep 11, 2020
@sadasant
Copy link
Contributor

Note from Heath, from the teams chat:

[1:10 PM] Heath Stewart
Service - KeyVault - hold off on implementing secure key release for now. The design is being changed after last week's service/client sync-up.

@heaths
Copy link
Member Author

heaths commented Sep 21, 2020

[9/16 2:54 PM] Heath Stewart
For now, hold off. I looped you all into a thread where MHSM just wants this as an opaque JSON blob, so model structure won't matter.

😉

@sadasant
Copy link
Contributor

I didn't see that on time! Thank you!

@sadasant
Copy link
Contributor

I'll push this for next month's release due to time budget.

@sadasant
Copy link
Contributor

Maor is currently assigned to the update and cleanup of the Key Vault Admin API. We won't be releasing export/release this month though, so we will likely push this issue for a later date, but in the mean time I'll keep this issue open so Maor can decide.

@heaths
Copy link
Member Author

heaths commented Jan 12, 2021

This should be moved out of February GA and done for 7.3-preview service version.

@maorleger maorleger removed the blocking-release Blocks release label Jan 25, 2021
@sadasant sadasant modified the milestones: [2021] March, [2021] April Mar 15, 2021
@maorleger maorleger modified the milestones: [2021] April, [2021] May Mar 29, 2021
@ramya-rao-a ramya-rao-a modified the milestones: [2021] May, Backlog Apr 8, 2021
@maorleger maorleger modified the milestones: Backlog, [2021] July Jun 17, 2021
@maorleger maorleger added the blocking-release Blocks release label Jun 17, 2021
@maorleger maorleger modified the milestones: [2021] July, [2021] August Jun 25, 2021
@maorleger
Copy link
Member

I created #16086 to support SKR. Key Export is not yet ready on the service side. Moving this to backlog

@maorleger maorleger modified the milestones: [2021] August, Backlog Jul 6, 2021
@maorleger maorleger removed the blocking-release Blocks release label Jul 6, 2021
@maorleger
Copy link
Member

This doesn't need to be tracked, let's add a new task when key export is ready on the service side.

@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

5 participants