Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyPermissions is missing a value #10705

Closed
CYoderDev opened this issue Aug 19, 2020 · 8 comments
Closed

KeyPermissions is missing a value #10705

CYoderDev opened this issue Aug 19, 2020 · 8 comments
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@CYoderDev
Copy link

export type KeyPermissions = 'encrypt' | 'decrypt' | 'wrapKey' | 'unwrapKey' | 'sign' | 'verify' | 'get' | 'list' | 'create' | 'update' | 'import' | 'delete' | 'backup' | 'restore' | 'recover' | 'purge';

The KeyPermissions, SecretPermissions, and CertificatePermissions types are missing the value all which is a possible value of access policy permissions when getting the key vault using the api and is supported by ARM template deployments.

Here is an example of an permissions of a access policy on a key vault that is returned by the api:

Permissions to Keys                        : {all}
Permissions to Secrets                     : {all}
Permissions to Certificates                : {all}
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 19, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. KeyVault labels Aug 19, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 19, 2020
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 19, 2020
@sadasant
Copy link
Contributor

Hello, @CYoderDev

Thank you for reaching out to us!

This issue will require further investigation, but so far I can say that:

I'll come back with a better response later today, or perhaps tomrorow.

@sadasant
Copy link
Contributor

@CYoderDev Update:

The "all" value as a permission is not present in Azure's public API for Key Vault: https://github.com/Azure/azure-rest-api-specs/blob/a7ca142c3f0f290fdda778f26f4f1fab65f71cf9/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json#L979-L1059

I wonder what are we missing! I'm still in communications with my team. I'll report back as soon as I have an update.

@sadasant sadasant added needs-author-feedback Workflow: More information is needed from author to address the issue. and removed needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Aug 24, 2020
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 1, 2020
@ghost
Copy link

ghost commented Sep 1, 2020

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@sadasant sadasant added Mgmt This issue is related to a management-plane library. Service Attention Workflow: This issue is responsible by Azure service team. and removed Client This issue points to a problem in the data-plane of the library. needs-author-feedback Workflow: More information is needed from author to address the issue. labels Sep 6, 2020
@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed no-recent-activity There has been no recent activity on this issue. labels Sep 6, 2020
@ghost
Copy link

ghost commented Sep 6, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @RandalliLama, @schaabs, @jlichwa.

@sadasant
Copy link
Contributor

sadasant commented Sep 6, 2020

I've switched this issue to be a service-level issue. Hopefully we'll get more answers this way.

@ramya-rao-a ramya-rao-a assigned RandalliLama and jlichwa and unassigned sadasant Sep 8, 2020
@jlichwa
Copy link

jlichwa commented Oct 5, 2020

Linked rest api PR - Azure/azure-rest-api-specs#11042

@sadasant
Copy link
Contributor

sadasant commented Oct 6, 2020

@jlichwa that looks cool! Thank you!

@sebansal
Copy link

Closing issue as its been addressed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. KeyVault Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

6 participants