From c7986415983734c979cc71be5c23544c4d7d9d8f Mon Sep 17 00:00:00 2001 From: XiaoningLiu Date: Fri, 12 Jun 2020 16:17:53 +0800 Subject: [PATCH] [Storage] Blob tags - resolve comments --- sdk/storage/storage-blob/review/storage-blob.api.md | 5 +---- sdk/storage/storage-blob/src/BlobSASPermissions.ts | 2 +- sdk/storage/storage-blob/src/BlobServiceClient.ts | 2 ++ sdk/storage/storage-blob/src/models.ts | 7 +------ 4 files changed, 5 insertions(+), 11 deletions(-) diff --git a/sdk/storage/storage-blob/review/storage-blob.api.md b/sdk/storage/storage-blob/review/storage-blob.api.md index 4d4118a8623d..3107c281fb5a 100644 --- a/sdk/storage/storage-blob/review/storage-blob.api.md +++ b/sdk/storage/storage-blob/review/storage-blob.api.md @@ -2694,10 +2694,7 @@ export class StorageSharedKeyCredentialPolicy extends CredentialPolicy { export type SyncCopyStatusType = 'success'; // @public -export interface Tags { - // (undocumented) - [propertyName: string]: string; -} +export type Tags = Record; // @public export interface UserDelegationKey { diff --git a/sdk/storage/storage-blob/src/BlobSASPermissions.ts b/sdk/storage/storage-blob/src/BlobSASPermissions.ts index 25a03b9b940f..f6b3c774c4ab 100644 --- a/sdk/storage/storage-blob/src/BlobSASPermissions.ts +++ b/sdk/storage/storage-blob/src/BlobSASPermissions.ts @@ -95,7 +95,7 @@ export class BlobSASPermissions { public delete: boolean = false; /** - * Specfies Tag access granted. + * Specifies Tag access granted. * * @type {boolean} * @memberof BlobSASPermissions diff --git a/sdk/storage/storage-blob/src/BlobServiceClient.ts b/sdk/storage/storage-blob/src/BlobServiceClient.ts index e969d543f92e..fff24db33399 100644 --- a/sdk/storage/storage-blob/src/BlobServiceClient.ts +++ b/sdk/storage/storage-blob/src/BlobServiceClient.ts @@ -834,6 +834,8 @@ export class BlobServiceClient extends StorageClient { * * .byPage() returns an async iterable iterator to list the blobs in pages. * + * @see https://docs.microsoft.com/en-us/rest/api/storageservices/get-blob-service-properties + * * Example using `for await` syntax: * * ```js diff --git a/sdk/storage/storage-blob/src/models.ts b/sdk/storage/storage-blob/src/models.ts index c6199b36d0cf..dec8da7e987b 100644 --- a/sdk/storage/storage-blob/src/models.ts +++ b/sdk/storage/storage-blob/src/models.ts @@ -13,13 +13,8 @@ import { EncryptionAlgorithmAES25 } from "./utils/constants"; /** * Blob tags. - * - * @export - * @interface Tags */ -export interface Tags { - [propertyName: string]: string; -} +export type Tags = Record; /** * A map of name-value pairs to associate with the resource.