From 52aeafd0c28370fb4f3b5ca5f1212c87d5c07bf3 Mon Sep 17 00:00:00 2001 From: Jeff Fisher Date: Thu, 21 Nov 2019 12:44:59 -0800 Subject: [PATCH] Update tsconfig for core packages (#6285) Update core packages to use common tsconfig and remove lib references where possible. --- sdk/core/abort-controller/src/AbortSignal.ts | 10 +-- sdk/core/abort-controller/tsconfig.json | 29 ++------ sdk/core/core-amqp/src/requestResponseLink.ts | 6 +- sdk/core/core-amqp/src/shims.d.ts | 2 + sdk/core/core-amqp/tsconfig.json | 35 ++-------- sdk/core/core-arm/.gitignore | 1 - sdk/core/core-arm/lib/shims.d.ts | 13 ++++ sdk/core/core-arm/tsconfig.json | 36 ++-------- .../core-asynciterator-polyfill/tsconfig.json | 25 +------ sdk/core/core-auth/src/tokenCredential.ts | 4 +- sdk/core/core-auth/test/index.spec.ts | 68 +++++++++++-------- sdk/core/core-auth/tsconfig.json | 60 +--------------- sdk/core/core-http/tsconfig.json | 26 +------ sdk/core/core-lro/.gitignore | 1 - sdk/core/core-lro/src/shims.d.ts | 27 ++++++++ sdk/core/core-lro/tsconfig.json | 18 +---- sdk/core/core-paging/tsconfig.json | 35 ++-------- sdk/core/logger/test/logger.spec.ts | 6 +- sdk/core/logger/tsconfig.json | 29 ++------ tsconfig.package.json | 4 +- 20 files changed, 131 insertions(+), 304 deletions(-) create mode 100644 sdk/core/core-arm/lib/shims.d.ts create mode 100644 sdk/core/core-lro/src/shims.d.ts diff --git a/sdk/core/abort-controller/src/AbortSignal.ts b/sdk/core/abort-controller/src/AbortSignal.ts index c9814d48968c..04e8e7500869 100644 --- a/sdk/core/abort-controller/src/AbortSignal.ts +++ b/sdk/core/abort-controller/src/AbortSignal.ts @@ -131,10 +131,12 @@ export class AbortSignal implements AbortSignalLike { } /** - * Dispatches a synthetic event to the AbortSignal. - */ - dispatchEvent(event: Event): boolean { - throw new Error("This is a stub dispatchEvent implementation that should not be used. It only exists for type-checking purposes.") + * Dispatches a synthetic event to the AbortSignal. + */ + dispatchEvent(_event: Event): boolean { + throw new Error( + "This is a stub dispatchEvent implementation that should not be used. It only exists for type-checking purposes." + ); } } diff --git a/sdk/core/abort-controller/tsconfig.json b/sdk/core/abort-controller/tsconfig.json index 98b8f2143270..6f18f95de133 100644 --- a/sdk/core/abort-controller/tsconfig.json +++ b/sdk/core/abort-controller/tsconfig.json @@ -1,30 +1,9 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - /* Basic Options */ - "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "es6" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, - "lib": [] /* lib dependencies are triple-slash directives in lib/index.ts */, - "declaration": true /* Generates corresponding '.d.ts' file. */, - "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "sourceMap": true /* Generates corresponding '.map' file. */, - "outDir": "./dist-esm" /* Redirect output structure to the directory. */, - "stripInternal": true /* Do not emit declarations for code with @internal annotation*/, - "declarationDir": "./types" /* Output directory for generated declaration files.*/, - "importHelpers": true /* Import emit helpers from 'tslib'. */, - /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, - "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, - /* Additional Checks */ - "noUnusedLocals": true /* Report errors on unused locals. */, - /* Module Resolution Options */ - "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, - "allowSyntheticDefaultImports": true /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */, - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, - /* Experimental Options */ - "forceConsistentCasingInFileNames": true, - /* Other options */ - "newLine": "LF" /* Use the specified end of line sequence to be used when emitting files: "crlf" (windows) or "lf" (unix).”*/, - "allowJs": false /* Don't allow JavaScript files to be compiled.*/ + "target": "es5", + "declarationDir": "./types", + "outDir": "./dist-esm" }, "compileOnSave": true, "exclude": ["node_modules", "./types/**/*.d.ts", "./samples/**/*.ts"], diff --git a/sdk/core/core-amqp/src/requestResponseLink.ts b/sdk/core/core-amqp/src/requestResponseLink.ts index d3da3a6cdbe1..5b32a305c842 100644 --- a/sdk/core/core-amqp/src/requestResponseLink.ts +++ b/sdk/core/core-amqp/src/requestResponseLink.ts @@ -81,9 +81,7 @@ export class RequestResponseLink implements ReqResLink { * @returns {Promise} Promise The AMQP (response) message. */ sendRequest(request: AmqpMessage, options: SendRequestOptions = {}): Promise { - if (!options.timeoutInMs) { - options.timeoutInMs = Constants.defaultOperationTimeoutInMs; - } + const timeoutInMs = options.timeoutInMs || Constants.defaultOperationTimeoutInMs; const aborter: AbortSignalLike | undefined = options.abortSignal; @@ -214,7 +212,7 @@ export class RequestResponseLink implements ReqResLink { return reject(translate(e)); }; - waitTimer = setTimeout(actionAfterTimeout, options.timeoutInMs); + waitTimer = setTimeout(actionAfterTimeout, timeoutInMs); this.receiver.on(ReceiverEvents.message, messageCallback); log.reqres( diff --git a/sdk/core/core-amqp/src/shims.d.ts b/sdk/core/core-amqp/src/shims.d.ts index 3b212004e2bd..3202311570b8 100644 --- a/sdk/core/core-amqp/src/shims.d.ts +++ b/sdk/core/core-amqp/src/shims.d.ts @@ -12,3 +12,5 @@ interface Window { readonly navigator: Navigator; } declare var navigator: Navigator; + +declare var window: Window; diff --git a/sdk/core/core-amqp/tsconfig.json b/sdk/core/core-amqp/tsconfig.json index 008f6441a69d..c4221d67216a 100644 --- a/sdk/core/core-amqp/tsconfig.json +++ b/sdk/core/core-amqp/tsconfig.json @@ -1,36 +1,9 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - /* Basic Options */ - "target": "es6" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "es6" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, - - "declaration": true /* Generates corresponding '.d.ts' file. */, - "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "sourceMap": true /* Generates corresponding '.map' file. */, - - "outDir": "./dist-esm" /* Redirect output structure to the directory. */, - "declarationDir": "./typings" /* Output directory for generated declaration files.*/, - - "importHelpers": true /* Import emit helpers from 'tslib'. */, - - /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, - "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, - - /* Additional Checks */ - "noUnusedLocals": true /* Report errors on unused locals. */, - - /* Module Resolution Options */ - "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, - "allowSyntheticDefaultImports": true /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */, - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, - - /* Experimental Options */ - "forceConsistentCasingInFileNames": true, - - /* Other options */ - "newLine": "LF" /* Use the specified end of line sequence to be used when emitting files: "crlf" (windows) or "lf" (unix).”*/, - "allowJs": false /* Don't allow JavaScript files to be compiled.*/, + "target": "es6", + "outDir": "./dist-esm", + "declarationDir": "./typings", "resolveJsonModule": true }, "compileOnSave": true, diff --git a/sdk/core/core-arm/.gitignore b/sdk/core/core-arm/.gitignore index b57ace249a0e..16a5dd52491d 100644 --- a/sdk/core/core-arm/.gitignore +++ b/sdk/core/core-arm/.gitignore @@ -7,7 +7,6 @@ package-lock.json .nyc_output/ coverage/ dist/ -*.d.ts *.d.ts.map *.js *.js.map diff --git a/sdk/core/core-arm/lib/shims.d.ts b/sdk/core/core-arm/lib/shims.d.ts new file mode 100644 index 000000000000..2ac4e2a6d8b1 --- /dev/null +++ b/sdk/core/core-arm/lib/shims.d.ts @@ -0,0 +1,13 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +// d.ts shims provide types for things we use internally but are not part +// of this package's surface area. + +interface RequestInit {} + +interface RequestInfo {} + +interface Response {} + +interface Headers {} diff --git a/sdk/core/core-arm/tsconfig.json b/sdk/core/core-arm/tsconfig.json index 2f191dc15858..7865a20387e9 100644 --- a/sdk/core/core-arm/tsconfig.json +++ b/sdk/core/core-arm/tsconfig.json @@ -1,38 +1,12 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - "module": "commonjs", "preserveConstEnums": true, - "sourceMap": true, - "newLine": "LF", + "module": "commonjs", "target": "es5", - "moduleResolution": "node", - "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, - "outDir": "dist", - "strict": true, - "declaration": true, - "declarationMap": true, - "importHelpers": true, - "esModuleInterop": true, - "allowSyntheticDefaultImports": true, - "lib": [ - "dom", - "dom.iterable", - "es5", - "es6", - "es7", - "esnext", - "esnext.asynciterable", - "es2015.iterable" - ] + "outDir": "es" }, "compileOnSave": true, - "exclude": [ - "node_modules" - ], - "include": [ - "./lib/**/*.ts", - "./test/**/*.ts" - ] + "exclude": ["node_modules"], + "include": ["./lib/**/*.ts", "./test/**/*.ts"] } diff --git a/sdk/core/core-asynciterator-polyfill/tsconfig.json b/sdk/core/core-asynciterator-polyfill/tsconfig.json index ec89f714a5cb..6cae3f95806a 100644 --- a/sdk/core/core-asynciterator-polyfill/tsconfig.json +++ b/sdk/core/core-asynciterator-polyfill/tsconfig.json @@ -1,30 +1,9 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { "module": "commonjs", - "sourceMap": true, - "newLine": "LF", "target": "es5", - "moduleResolution": "node", - "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, - "outDir": "./dist-esm", - "strict": true, - "declaration": true, - "declarationMap": true, - "importHelpers": true, - "esModuleInterop": true, - "allowSyntheticDefaultImports": true, - "lib": [ - "dom", - "dom.iterable", - "es5", - "es6", - "es7", - "esnext", - "esnext.asynciterable", - "es2015.iterable" - ] + "outDir": "./dist-esm" }, "compileOnSave": true, "exclude": ["node_modules"], diff --git a/sdk/core/core-auth/src/tokenCredential.ts b/sdk/core/core-auth/src/tokenCredential.ts index 6debddd3b030..592ca23d4d3e 100644 --- a/sdk/core/core-auth/src/tokenCredential.ts +++ b/sdk/core/core-auth/src/tokenCredential.ts @@ -1,7 +1,6 @@ // Copyright (c) Microsoft Corporation. // Licensed under the MIT License. -import { AbortSignalLike } from "@azure/abort-controller"; import { OperationOptions } from "./operationOptions"; /** @@ -21,8 +20,7 @@ export interface TokenCredential { /** * Defines options for TokenCredential.getToken. */ -export interface GetTokenOptions extends OperationOptions { -} +export interface GetTokenOptions extends OperationOptions {} /** * Represents an access token with an expiration time. diff --git a/sdk/core/core-auth/test/index.spec.ts b/sdk/core/core-auth/test/index.spec.ts index 5f3a3da31d2f..ae955fdd29a1 100644 --- a/sdk/core/core-auth/test/index.spec.ts +++ b/sdk/core/core-auth/test/index.spec.ts @@ -4,43 +4,57 @@ import assert from "assert"; import { isTokenCredential } from "../src/tokenCredential"; -describe("isTokenCredential", function () { +describe("isTokenCredential", function() { it("should return true for an object that resembles a TokenCredential", () => { - assert.ok(isTokenCredential({ - getToken() { - return Promise.resolve({ - token: "secret", - expiresOnTimestamp: 12345 - }); - } - })); + assert.ok( + isTokenCredential({ + getToken() { + return Promise.resolve({ + token: "secret", + expiresOnTimestamp: 12345 + }); + } + }) + ); }); it("should return false for an object that does not resemble a TokenCredential", () => { - assert.strictEqual(isTokenCredential({ - doStuff() { - return false; - } - }), false); + assert.strictEqual( + isTokenCredential({ + doStuff() { + return false; + } + }), + false + ); }); it("should return false for an object that has a non-function field named 'getToken'", () => { - assert.strictEqual(isTokenCredential({ - getToken: true - }), false); + assert.strictEqual( + isTokenCredential({ + getToken: true + }), + false + ); }); it("should return false for an object that has a 'signRequest' field and getToken that takes no parameters", () => { - assert.strictEqual(isTokenCredential({ - getToken: function () { }, - signRequest: function() { }, - }), false); - }) + assert.strictEqual( + isTokenCredential({ + getToken: function() {}, + signRequest: function() {} + }), + false + ); + }); it("should return true for an object that has a 'signRequest' field and getToken that takes parameters", () => { - assert.strictEqual(isTokenCredential({ - getToken: function (scope: string) { }, - signRequest: function() { }, - }), true); - }) + assert.strictEqual( + isTokenCredential({ + getToken: function(_scope: string) {}, + signRequest: function() {} + }), + true + ); + }); }); diff --git a/sdk/core/core-auth/tsconfig.json b/sdk/core/core-auth/tsconfig.json index 2e1218772c63..4f5fa20b2111 100644 --- a/sdk/core/core-auth/tsconfig.json +++ b/sdk/core/core-auth/tsconfig.json @@ -1,61 +1,7 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - /* Basic Options */ - "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "es6" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, - // "lib": [], /* Specify library files to be included in the compilation. */ - // "allowJs": true, /* Allow javascript files to be compiled. */ - // "checkJs": true, /* Report errors in .js files. */ - // "jsx": "preserve", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ - "declaration": true /* Generates corresponding '.d.ts' file. */, - "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "declarationDir": "./types" /* Output directory for generated declaration files.*/, - "sourceMap": true /* Generates corresponding '.map' file. */, - // "outFile": "./", /* Concatenate and emit output to single file. */ - "outDir": "./dist-esm" /* Redirect output structure to the directory. */, - // "rootDir": "." /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */, - // "composite": true, /* Enable project compilation */ - // "removeComments": true, /* Do not emit comments to output. */ - // "noEmit": true, /* Do not emit outputs. */ - "importHelpers": true /* Import emit helpers from 'tslib'. */, - // "downlevelIteration": true, /* Provide full support for iterables in 'for-of', spread, and destructuring when targeting 'ES5' or 'ES3'. */ - // "isolatedModules": true, /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */ - - /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, - // "noImplicitAny": true, /* Raise error on expressions and declarations with an implied 'any' type. */ - // "strictNullChecks": true, /* Enable strict null checks. */ - // "strictFunctionTypes": true, /* Enable strict checking of function types. */ - // "strictPropertyInitialization": true, /* Enable strict checking of property initialization in classes. */ - // "noImplicitThis": true, /* Raise error on 'this' expressions with an implied 'any' type. */ - // "alwaysStrict": true, /* Parse in strict mode and emit "use strict" for each source file. */ - - /* Additional Checks */ - // "noUnusedLocals": true, /* Report errors on unused locals. */ - // "noUnusedParameters": true, /* Report errors on unused parameters. */ - // "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */ - // "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */ - - /* Module Resolution Options */ - "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, - // "baseUrl": "./", /* Base directory to resolve non-absolute module names. */ - // "paths": {}, /* A series of entries which re-map imports to lookup locations relative to the 'baseUrl'. */ - // "rootDirs": [] /* List of root folders whose combined content represents the structure of the project at runtime. */, - // "typeRoots": [], /* List of folders to include type definitions from. */ - // "types": [], /* Type declaration files to be included in compilation. */ - "allowSyntheticDefaultImports": true /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */, - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, - // "preserveSymlinks": true, /* Do not resolve the real path of symlinks. */ - - /* Source Map Options */ - // "sourceRoot": "", /* Specify the location where debugger should locate TypeScript files instead of source locations. */ - // "mapRoot": "", /* Specify the location where debugger should locate map files instead of generated locations. */ - // "inlineSourceMap": true, /* Emit a single file with source maps instead of having a separate file. */ - // "inlineSources": true, /* Emit the source alongside the sourcemaps within a single file; requires '--inlineSourceMap' or '--sourceMap' to be set. */ - - /* Experimental Options */ - // "experimentalDecorators": true, /* Enables experimental support for ES7 decorators. */ - // "emitDecoratorMetadata": true, /* Enables experimental support for emitting type metadata for decorators. */ - "forceConsistentCasingInFileNames": true + "declarationDir": "./types", + "outDir": "./dist-esm" } } diff --git a/sdk/core/core-http/tsconfig.json b/sdk/core/core-http/tsconfig.json index c4ea5684971d..8a90b13da1ea 100644 --- a/sdk/core/core-http/tsconfig.json +++ b/sdk/core/core-http/tsconfig.json @@ -1,30 +1,10 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { "module": "commonjs", - "sourceMap": true, - "newLine": "LF", - "target": "es5", - "moduleResolution": "node", - "noImplicitReturns": true, - "noUnusedLocals": true, - "noUnusedParameters": true, "outDir": "dist", - "strict": true, - "declaration": true, - "declarationMap": true, - "importHelpers": true, - "esModuleInterop": true, - "allowSyntheticDefaultImports": true, - "lib": [ - "dom", - "dom.iterable", - "es5", - "es6", - "es7", - "esnext", - "esnext.asynciterable", - "es2015.iterable" - ] + "target": "es5", + "lib": ["dom"] }, "compileOnSave": true, "exclude": ["node_modules"], diff --git a/sdk/core/core-lro/.gitignore b/sdk/core/core-lro/.gitignore index adbe9cef4efc..e6fbceb18938 100644 --- a/sdk/core/core-lro/.gitignore +++ b/sdk/core/core-lro/.gitignore @@ -7,7 +7,6 @@ package-lock.json .nyc_output/ coverage/ dist/ -*.d.ts *.d.ts.map *.js *.js.map diff --git a/sdk/core/core-lro/src/shims.d.ts b/sdk/core/core-lro/src/shims.d.ts new file mode 100644 index 000000000000..c22749fe94f2 --- /dev/null +++ b/sdk/core/core-lro/src/shims.d.ts @@ -0,0 +1,27 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +// d.ts shims provide types for things we use internally but are not part +// of this package's surface area. + +interface AbortSignal { + readonly aborted: boolean; + addEventListener( + type: "abort", + listener: (this: AbortSignal, ev: any) => any, + options?: any + ): void; + removeEventListener( + type: "abort", + listener: (this: AbortSignal, ev: any) => any, + options?: any + ): void; +} + +interface RequestInit {} + +interface RequestInfo {} + +interface Response {} + +interface Headers {} diff --git a/sdk/core/core-lro/tsconfig.json b/sdk/core/core-lro/tsconfig.json index 30c38a54b66e..9e64b126833c 100644 --- a/sdk/core/core-lro/tsconfig.json +++ b/sdk/core/core-lro/tsconfig.json @@ -1,23 +1,9 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - "alwaysStrict": true, - "noImplicitAny": true, - "preserveConstEnums": true, - "sourceMap": true, - "newLine": "LF", "target": "es5", - "moduleResolution": "node", - "noUnusedLocals": true, - "noUnusedParameters": true, - "strict": true, - "module": "esNext", "outDir": "./dist-esm", - "declaration": true, - "declarationMap": true, - "importHelpers": true, - "declarationDir": "./types", - "lib": ["dom", "es5", "es6", "es7", "esnext"], - "esModuleInterop": true + "declarationDir": "./types" }, "compileOnSave": true, "exclude": ["node_modules", "./samples/**/*.ts"], diff --git a/sdk/core/core-paging/tsconfig.json b/sdk/core/core-paging/tsconfig.json index d5bd64fbe1f9..4cf2eedb4beb 100644 --- a/sdk/core/core-paging/tsconfig.json +++ b/sdk/core/core-paging/tsconfig.json @@ -1,35 +1,12 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - /* Basic Options */ - "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, - "lib": [] /* lib dependencies are triple-slash directives in lib/index.ts */, - "declaration": false /* Generates corresponding '.d.ts' file. */, - "declarationMap": false /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "sourceMap": false /* Generates corresponding '.map' file. */, - + "module": "commonjs", + "target": "es5", + "declaration": false, + "declarationMap": false, + "sourceMap": false, "outDir": "./dist-esm", - "stripInternal": true /* Do not emit declarations for code with @internal annotation*/, - "importHelpers": true /* Import emit helpers from 'tslib'. */, - - /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, - "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, - - /* Additional Checks */ - "noUnusedLocals": true /* Report errors on unused locals. */, - - /* Module Resolution Options */ - "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, - "allowSyntheticDefaultImports": true /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */, - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, - - /* Experimental Options */ - "forceConsistentCasingInFileNames": true, - - /* Other options */ - "newLine": "LF" /* Use the specified end of line sequence to be used when emitting files: "crlf" (windows) or "lf" (unix).”*/, - "allowJs": false /* Don't allow JavaScript files to be compiled.*/, "resolveJsonModule": true }, "compileOnSave": true, diff --git a/sdk/core/logger/test/logger.spec.ts b/sdk/core/logger/test/logger.spec.ts index ca6701a1cf6a..c7fc4b414eee 100644 --- a/sdk/core/logger/test/logger.spec.ts +++ b/sdk/core/logger/test/logger.spec.ts @@ -65,8 +65,8 @@ describe("setLogLevel", () => { it("throws when setting to an unknown log level", () => { assert.throws(() => { - Logger.setLogLevel('debug' as any); - }, /Unknown log level/) + Logger.setLogLevel("debug" as any); + }, /Unknown log level/); }); }); @@ -77,7 +77,7 @@ describe("ClientLoggers", () => { const oldLog = Logger.AzureLogger.log.bind(Logger.AzureLogger); let called = false; - Logger.AzureLogger.log = (...args) => { + Logger.AzureLogger.log = () => { called = true; }; diff --git a/sdk/core/logger/tsconfig.json b/sdk/core/logger/tsconfig.json index 2a274ef0dcca..902eb6fe955e 100644 --- a/sdk/core/logger/tsconfig.json +++ b/sdk/core/logger/tsconfig.json @@ -1,30 +1,9 @@ { + "extends": "../../../tsconfig.package", "compilerOptions": { - /* Basic Options */ - "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, - "module": "es6" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, - "lib": [] /* lib dependencies are triple-slash directives in lib/index.ts */, - "declaration": true /* Generates corresponding '.d.ts' file. */, - "declarationMap": true /* Generates a sourcemap for each corresponding '.d.ts' file. */, - "sourceMap": true /* Generates corresponding '.map' file. */, - "outDir": "./dist-esm" /* Redirect output structure to the directory. */, - "stripInternal": true /* Do not emit declarations for code with @internal annotation*/, - "declarationDir": "./types" /* Output directory for generated declaration files.*/, - "importHelpers": true /* Import emit helpers from 'tslib'. */, - /* Strict Type-Checking Options */ - "strict": true /* Enable all strict type-checking options. */, - "noImplicitReturns": true /* Report error when not all code paths in function return a value. */, - /* Additional Checks */ - "noUnusedLocals": true /* Report errors on unused locals. */, - /* Module Resolution Options */ - "moduleResolution": "node" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, - "allowSyntheticDefaultImports": true /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */, - "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, - /* Experimental Options */ - "forceConsistentCasingInFileNames": true, - /* Other options */ - "newLine": "LF" /* Use the specified end of line sequence to be used when emitting files: "crlf" (windows) or "lf" (unix).”*/, - "allowJs": false /* Don't allow JavaScript files to be compiled.*/, + "target": "es5", + "outDir": "./dist-esm", + "declarationDir": "./types", "downlevelIteration": true }, "compileOnSave": true, diff --git a/tsconfig.package.json b/tsconfig.package.json index ebdc36d1b143..3a3efd6ae6ba 100644 --- a/tsconfig.package.json +++ b/tsconfig.package.json @@ -1,4 +1,6 @@ { "extends": "./tsconfig", - "module": "es6" + "compilerOptions": { + "module": "es6" + } }