Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From source update #14035

Merged
merged 12 commits into from
Aug 14, 2020
Merged

From source update #14035

merged 12 commits into from
Aug 14, 2020

Conversation

JimSuplizio
Copy link
Member

The idea here is to try and remove the snafu that's happening from the usage of the From Source runs requiring a metric ton of AdditionalModules. The changes are as follows:

  • For the From Source runs, build and install all of the client libraries. Note that the root pom.xml has both tracks in it, and because of that I generate a client only aggregate pom file to build.
  • Remove the -am switch from the From Source runs. This was over-running. When building libraries for a given sdk/area we don't about running tests for our dependencies, we only care about running tests for things that depend on us.
  • Remove the unnecessary AdditionalModules from ci.yml files. Note: in this case it's just identity's ci.yml for testing and concept purposes. If this works I'll flush the rest of the unnecessary additional modules.
  • When calling update_versions.py, we weren't passing in the --sr to skip readme/changelog updates. Because the changelog updates use common code which is powershell that means we're having to create a separate process to call this. This was adding 1-3 minutes onto a step that should take about 10 seconds to run.
  • Put the dependency checker for the bom file build inside of a profile. This is what we're doing in the azure-client-sdk-parent and we're passing in -Ddependency-checker on the command line. I did the same for the POM build so we're consistent here.
  • Move the allow list generation under the dependency-checker since it's not useful outside of the aggregate reports and though it takes several seconds to run, there are 100+ libraries to build.

@JimSuplizio JimSuplizio marked this pull request as draft August 12, 2020 21:30
@JimSuplizio
Copy link
Member Author

/azp run java - identity - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio
Copy link
Member Author

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JimSuplizio
Copy link
Member Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio
Copy link
Member Author

/azp run java - cosmos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio
Copy link
Member Author

/azp run java - cosmos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio
Copy link
Member Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio JimSuplizio marked this pull request as ready for review August 13, 2020 22:50
@JimSuplizio
Copy link
Member Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio
Copy link
Member Author

/azp run java - appconfiguration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JimSuplizio JimSuplizio merged commit 3ac56c8 into master Aug 14, 2020
@JimSuplizio JimSuplizio deleted the FromSourceUpdate branch August 14, 2020 15:43
@hemanttanwar hemanttanwar mentioned this pull request Aug 26, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request May 25, 2021
@iscai-msft @RAY-316 @msyyc
CodeGen from PR 14035 in Azure/azure-rest-api-specs
32826ab 
Fix to support nextLink with post calls for python sdk (Azure#14035)

* single example with post nextLinl

* address suggestions

* remove examples

* Add nextLink param

* Post on nextLink for all requests

* Add api-version as param

* update readme

* prettier fix

* fix lint err try

* rename operation id

* fix generation for python

* fix casing of next link

* Remove package

* change one next link op to normal path

* readme.python config

* Update readme.python.md

Co-authored-by: Namrata Jagasia <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Zed <[email protected]>
Co-authored-by: msyyc <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-java that referenced this pull request Jul 16, 2021
@iscai-msft @RAY-316 @msyyc
CodeGen from PR 14035 in Azure/azure-rest-api-specs
b1230f7 
Fix to support nextLink with post calls for python sdk (Azure#14035)

* single example with post nextLinl

* address suggestions

* remove examples

* Add nextLink param

* Post on nextLink for all requests

* Add api-version as param

* update readme

* prettier fix

* fix lint err try

* rename operation id

* fix generation for python

* fix casing of next link

* Remove package

* change one next link op to normal path

* readme.python config

* Update readme.python.md

Co-authored-by: Namrata Jagasia <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Zed <[email protected]>
Co-authored-by: msyyc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@mitchdenny mitchdenny mitchdenny approved these changes

@anuchandy anuchandy Awaiting requested review from anuchandy

@danieljurek danieljurek Awaiting requested review from danieljurek

@g2vinay g2vinay Awaiting requested review from g2vinay

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@joshfree joshfree Awaiting requested review from joshfree

@schaabs schaabs Awaiting requested review from schaabs

@srnagar srnagar Awaiting requested review from srnagar

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimSuplizio @mitchdenny @alzimmermsft