Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java Repo doesn't follow Azure SDK team directory structure #5682

Closed
joshfree opened this issue Oct 3, 2019 · 4 comments
Closed

Java Repo doesn't follow Azure SDK team directory structure #5682

joshfree opened this issue Oct 3, 2019 · 4 comments
Assignees
@weidongxu-microsoft
Labels
Mgmt This issue is related to a management-plane library.

Comments

@joshfree
Copy link
Member

joshfree commented Oct 3, 2019

Related #2847

The azure/azure-sdk-for-java repo has a large number of management plane SDKs in the top level directory. These all need to be moved under sdk/ with their supporting build pipeline, auto-pr-bot, and CODEOWNERS entries updated accordingly.

I believe Java is the last repo which is yet to be updated to match this directory structure convention under the azure/azure-sdk-for-* repos.
@joshfree joshfree added the EngSys This issue is impacting the engineering system. label Oct 3, 2019
@joshfree
Copy link
Member Author

joshfree commented Oct 3, 2019

cc: @weshaggard @kurtzeborn @mitchdenny @JimSuplizio

@weshaggard
Copy link
Member

FYI this is something that @weidongxu-microsoft is working on in #5378

@yaohaizh yaohaizh added the Mgmt This issue is related to a management-plane library. label Oct 11, 2019
@kurtzeborn kurtzeborn removed the EngSys This issue is impacting the engineering system. label Oct 15, 2019
This was referenced Nov 12, 2019
Merged
Merged
Merged
Closed
Merged
@weidongxu-microsoft
Copy link
Member

There is "data-plane" inside "eventhubs". So this folder under project root is not cleaned.

This was referenced Nov 15, 2019
Merged
Closed
@weidongxu-microsoft
Copy link
Member

PR on SDK and PR on swagger spec is all merged.

PR on autorest.java is yet to merge, but since now mgmt SDK is at same level under project root as before, relativePath of pom.xml no longer need to be changed, so this PR is no longer mandatory for this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mitchdenny @joshfree @weshaggard @JimSuplizio @yaohaizh @kurtzeborn @weidongxu-microsoft