Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Progress Reporting #5243

Closed
rickle-msft opened this issue Sep 4, 2019 · 1 comment · Fixed by #5730
Closed

Storage Progress Reporting #5243

rickle-msft opened this issue Sep 4, 2019 · 1 comment · Fixed by #5730
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@rickle-msft
Copy link
Contributor

rickle-msft commented Sep 4, 2019

Code looks to be already ported from v11. It needs to be tied into bulk upload/download methods

The only work should be in any methods with parallel transfer (upload from file, download to file, and buffered upload).

No work needs to be done for the basic upload/download methods

ParallelTransferOptions should accept an IProgressReporter.
In each of the necessary methods, the work should be to instantiate a mutex and an atomicLong before the parallel operation begins and then on each data stream (e.g. a chunk from a file), call ProgressReporter.addParallelProgressReporting and pass in these two values along with the IProgressReporter.

Most of this is already done in buffered upload but is commented out.
Examples of what this should look like for the file transfer operations can be found in the TransferManager type in v11 (microsoft.azure package)

Tests for this should also exist in the v11 test suite and should be able to be translated pretty directly to track 2 (v12)

@kaerm kaerm added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Sep 4, 2019
@triage-new-issues triage-new-issues bot removed the triage label Sep 4, 2019
@kurtzeborn
Copy link
Member

@vhvb1989, talk to @alzimmermsft if you have questions about how to get started on this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants