Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent resource path management between client classes #4543

Closed
jaschrep-msft opened this issue Jul 23, 2019 · 1 comment
Closed

Inconsistent resource path management between client classes #4543

jaschrep-msft opened this issue Jul 23, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@jaschrep-msft
Copy link
Member

Different clients manage url paths differently.
File clients don't return the complete url in their get url methods.

All clients across blob/file/queue should:

  • Store the url scheme, host, and path in the "impl" client.
  • Store the snapshot in the handwritten client.
  • Include the snapshot, if any on methods that get the client's url.
@jaschrep-msft jaschrep-msft added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Jul 23, 2019
@jaschrep-msft jaschrep-msft self-assigned this Jul 23, 2019
@jaschrep-msft
Copy link
Member Author

Point 1 as originally stated is not necessary. I believe queue client implementation details actually force choosing the other path. All clients should follow that for consistency.

@sima-zhu sima-zhu closed this as completed Oct 1, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

2 participants