Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the return value of forceCloseHandles API #4525

Closed
sima-zhu opened this issue Jul 22, 2019 · 4 comments
Closed

Refine the return value of forceCloseHandles API #4525

sima-zhu opened this issue Jul 22, 2019 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@sima-zhu
Copy link
Contributor

We return Iterable currently which might not make sense to customer. Think about to return how many handles actually closed.

Need two APIs:

  1. with handleId as arg
  2. without args for forceCloseAll
@sima-zhu
Copy link
Contributor Author

@alzimmermsft

@sima-zhu sima-zhu added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. and removed triage labels Jul 22, 2019
@kurtzeborn
Copy link
Member

@alzimmermsft, you were saying the only useful data the REST api returns is integers. Take a look and if that's correct, there's not much we can do here, so it should be closed.

@alzimmermsft
Copy link
Member

The return type of the methods have been changed to PagedFlux<Integer> and PagedIterable<Integer> which is correct based on the API documentation. The API will need to be updated to include better overloads.

@vhvb1989 vhvb1989 changed the title Refine the return value of forceCloseHandles API Add x-ms-recursive to forceCloseHandles API Sep 16, 2019
@vhvb1989
Copy link
Member

No need to add a new API overload for closeAll() since this method can take an asterisk ('*') as a wildcard string to specify all handles and that is documented in JavaDoc

@vhvb1989 vhvb1989 changed the title Add x-ms-recursive to forceCloseHandles API forceCloseHandles API Sep 16, 2019
@vhvb1989 vhvb1989 changed the title forceCloseHandles API Refine the return value of forceCloseHandles API Sep 16, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

6 participants