Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common module for blob, queue and file. #4431

Closed
sima-zhu opened this issue Jul 15, 2019 · 1 comment
Closed

Added common module for blob, queue and file. #4431

sima-zhu opened this issue Jul 15, 2019 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@sima-zhu
Copy link
Contributor

Currently, blob, queue and file share the exactly same common pkg. I would be better to add a common module for the reasons:

  1. We do not have duplicate code for 3 services.
  2. No need to make extra efforts every time we update the common module. Like SAS token.

Work need to be done for common module.

  1. Extract the common func to a new module.
  2. Added Junit tests
  3. Remove the common pkg in each service and the refer to the common module.
@sima-zhu sima-zhu added the Storage Storage Service (Queues, Blobs, Files) label Jul 15, 2019
@sima-zhu sima-zhu self-assigned this Jul 15, 2019
@sima-zhu
Copy link
Contributor Author

@sima-zhu sima-zhu added the Client This issue points to a problem in the data-plane of the library. label Jul 15, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

2 participants