Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default Logging and Redactions of Logs #4328

Closed
alzimmermsft opened this issue Jul 8, 2019 · 6 comments
Closed

Add Default Logging and Redactions of Logs #4328

alzimmermsft opened this issue Jul 8, 2019 · 6 comments
Assignees
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@alzimmermsft
Copy link
Member

alzimmermsft commented Jul 8, 2019

Add a default, always-on, logger and enhance logging to redact sensitive information (secrets, passwords, etc) from the logs.

@alzimmermsft alzimmermsft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) and removed triage labels Jul 9, 2019
@alzimmermsft alzimmermsft changed the title Add Logging with Redactions Add Default Logging and Redactions of Logs Jul 17, 2019
@amishra-dev
Copy link

amishra-dev commented Jul 18, 2019

@alzimmermsft In addition to redacting, we also must implement that if a task is running for more than 2 seconds we write the CPU/Memory (Disk and network if we can) into the default log.
@rickle-msft fyi

@joshfree
Copy link
Member

joshfree commented Oct 9, 2019

@samvaity could you please drive this to resolution for Preview 5?

@rickle-msft
Copy link
Contributor

I'm not sure if I've shared this elsewhere, but we'd really like to get the items discussed in #5130 included in whichever PR related to logs comes out next

@rickle-msft
Copy link
Contributor

Another customer request is to log which retry number we are on. See here

@JonathanGiles
Copy link
Member

@samvaity Can this issue be closed (for redaction), with the follow-up requests filed in new issues that are not considered release blocking?

@samvaity
Copy link
Member

Closing this as the redaction of sensitive information from logs is already merged in #5688

New issues filed for the other two logging improvements: #5773, #5774

@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

6 participants