Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we trim quotes from etag #4246

Closed
1 task
anuchandy opened this issue Jul 3, 2019 · 0 comments
Closed
1 task

Should we trim quotes from etag #4246

anuchandy opened this issue Jul 3, 2019 · 0 comments
Assignees
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@anuchandy
Copy link
Member

Is your feature request related to a problem? Please describe.

Storage service is inconsistent in whether or not the etag header value has quotes.

Describe the solution you'd like

I wanted to use this issue to discuss this instead of going ahead and putting code for it in runtime (which is easy), is this right thing to do? are there multiple azure services behaving like this? is this something that can be fixed in server side?

Describe alternatives you've considered
Today storage SDK uses reflection to identify etag and trim it https://github.com/alzimmermsft/azure-sdk-for-java/blob/2f44585d00f2292b95828ac7f357b239413c95ef/storage/client/src/main/java/com/azure/storage/blob/Utility.java#L277

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • [X ] Description Added
  • Expected solution specified
@anuchandy anuchandy added the Client This issue points to a problem in the data-plane of the library. label Jul 3, 2019
@jianghaolu jianghaolu added Azure.Core azure-core Storage Storage Service (Queues, Blobs, Files) labels Jul 17, 2019
@jianghaolu jianghaolu self-assigned this Jul 17, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core azure-core Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants